GStreamer should not return "yes" for canPlayType("video/mp4")

RESOLVED FIXED in mozilla16

Status

()

Core
Audio/Video
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: roc, Assigned: Alessandro Decina)

Tracking

Trunk
mozilla16
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

I was just looking at the nsHTMLMediaElement code and noticed that CanHandleMediaType returns CANPLAY_YES for video/mp4 etc. This is incorrect; it should behave like Ogg and WAV and return CANPLAY_MAYBE as the value to be used if "codecs" is not present in the MIME type (unless we know for sure that GStreamer can play every codec that could possibly be present in an MP4 file, which I doubt).
(Assignee)

Comment 1

5 years ago
Created attachment 629515 [details] [diff] [review]
Fix
Attachment #629515 - Flags: review?
Comment on attachment 629515 [details] [diff] [review]
Fix

Review of attachment 629515 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

BTW, best not to ask for review from the wind :-)
Attachment #629515 - Flags: review? → review+
(Assignee)

Updated

5 years ago
Attachment #629515 - Flags: checkin?(chris.double)

Updated

5 years ago
Attachment #629515 - Flags: checkin?(chris.double)

Updated

5 years ago
Status: NEW → ASSIGNED
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/feb05d048eed
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/feb05d048eed
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.