756965 - mozilla::ThreadLocal only allows pointers

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Mike Hommey [:glandium]]

There are several cases, including the examples given in ThreadLocal.h, where ThreadLocal may be used with integer types, which is actually not possible with the current implementation (which makes the example code wrong). Also, since the type given to the template is not exactly the one returned by get() and taken by set(), it's not entirely clear when writing a ThreadLocal variable definition what its type actually is.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Allow mozilla::ThreadLocal to store integer types smaller than, or as large as, a pointer

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 625561 [details] [diff] [review]
Allow mozilla::ThreadLocal to store integer types smaller than, or as large as, a pointer

Review of attachment 625561 [details] [diff] [review]:
-----------------------------------------------------------------

Seems reasonable.

::: mfbt/ThreadLocal.h
@@ +74,5 @@
>  
> +    typedef union {
> +      void *ptr;
> +      T value;
> +    } helper;

Just |union Helper|, please.  The typedef here is unnecessary, since everything using this is a member of ThreadLocal for name lookup purposes.  And it should be InterCaps-named like everything else.

Comment 3

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b3570567bd5d

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b3570567bd5d