don't calculate rendering text when calculating visibility state

RESOLVED WONTFIX

Status

()

Core
Disability Access APIs
RESOLVED WONTFIX
6 years ago
6 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 625566 [details] [diff] [review]
patch

we spend about 1% for that per test case of bug 732872 but this doesn't make sense at all since we don't create accessible having no rendered text and we keep its rendered text cached (so in the case when frame doesn't have rendered text anymore but we didn't destroyed an accessible yet then it's considered that accessible still has a rendered text).
Attachment #625566 - Flags: review?(trev.saunders)
(Assignee)

Comment 1

6 years ago
Created attachment 625567 [details] [diff] [review]
patch2

correct patch
Attachment #625566 - Attachment is obsolete: true
Attachment #625566 - Flags: review?(trev.saunders)
Attachment #625567 - Flags: review?(trev.saunders)
(Assignee)

Comment 2

6 years ago
Comment on attachment 625567 [details] [diff] [review]
patch2

on the another hand it makes us out of sync with accessible boundaries which are empty in this case so we should expose invisible state for correctness
Attachment #625567 - Flags: review?(trev.saunders)
(Assignee)

Comment 3

6 years ago
wontfix per comment #2
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.