Closed
Bug 757045
Opened 13 years ago
Closed 13 years ago
Bughunter - fix checking for fatal errors
Categories
(Testing Graveyard :: Sisyphus, defect)
Testing Graveyard
Sisyphus
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bc, Assigned: bc)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
11.34 KB,
patch
|
Details | Diff | Splinter Review |
Sisyphus shell scripts detect fatal errors through an error trap which checks the exit code of the script and if it is not expected, emit indications of fatal errors to both the test logs and to stderr by emitting a line beginning with FATAL ERROR. Bug 733821 introduced a call to a shell function used in debugging output which inadvertently hid the real exit code from the exit trap.
Ride alongs for this bug are the removal of the unused standalone python/sisyphus/automation/builder.py and the changing of several Popen calls to consistently duplicate stderr to stdout to simplify log processing for fatal errors.
|
Assignee | |
Comment 1•13 years ago
|
||
|
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•13 years ago
|
||
follow up to handle spurious exit code 1 from external commands:
http://hg.mozilla.org/automation/sisyphus/rev/446f8b60b04f
|
||
Updated•7 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•