Last Comment Bug 757060 - redit fails to compile on mingw due to wmain linkage error
: redit fails to compile on mingw due to wmain linkage error
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: Firefox 15
Assigned To: Jacek Caban
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-21 08:34 PDT by Jacek Caban
Modified: 2012-05-23 08:05 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix v1.0 (1.12 KB, patch)
2012-05-21 08:34 PDT, Jacek Caban
mh+mozilla: review+
Details | Diff | Review

Description Jacek Caban 2012-05-21 08:34:31 PDT
Created attachment 625656 [details] [diff] [review]
fix v1.0

mingw in mingw-w64 version has limited support for wmain entry point, which was introduced by bug 753123. It requires explicit -municode in linker options and explicit extern "C" in source. The attached patch takes care of that.
Comment 1 Jacek Caban 2012-05-22 01:44:57 PDT
Thanks for quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/eef8337cde96
Comment 2 Ed Morley [:emorley] 2012-05-23 08:05:47 PDT
https://hg.mozilla.org/mozilla-central/rev/eef8337cde96

Note You need to log in before you can comment on or make changes to this bug.