redit fails to compile on mingw due to wmain linkage error

RESOLVED FIXED in Firefox 15

Status

()

Firefox
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

unspecified
Firefox 15
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 625656 [details] [diff] [review]
fix v1.0

mingw in mingw-w64 version has limited support for wmain entry point, which was introduced by bug 753123. It requires explicit -municode in linker options and explicit extern "C" in source. The attached patch takes care of that.
Attachment #625656 - Flags: review?(mh+mozilla)
Attachment #625656 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 1

5 years ago
Thanks for quick review!

https://hg.mozilla.org/integration/mozilla-inbound/rev/eef8337cde96
Target Milestone: --- → Firefox 15

Comment 2

5 years ago
https://hg.mozilla.org/mozilla-central/rev/eef8337cde96
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.