Multiple access keys used in preferences dialog for ff locale

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
9 months ago

People

(Reporter: whimboo, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-l10n], URL)

Attachments

(1 attachment)

794.34 KB, application/force-download
Details
(Reporter)

Description

6 years ago
Our Mozmill l10n tests have been shown that there is a huge list of access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/f87375a634b1a5ba746e5f763a3fc8cb

Details:

 	

    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: (id is undefined), label: (label is undefined)]
    accessKey: a found in strings: [id: loadImages, label: Loow nate ɗee e jaajol], [id: (id is undefined), label: Paltooje…]
    accessKey: f found in strings: [id: popupPolicy, label: Falo kenorɗe cuppitte], [id: (id is undefined), label: (label is undefined)]
    accessKey: d found in strings: [id: moveResizePopupWindows, label: Dirtin walla waylu ɓetol kenorɗe cuppitte], [id: disableContextMenus, label: Daaƴ walla lomtin dosi loowdi]
    accessKey: a found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
    accessKey: p found in strings: [id: (id is undefined), label: (label is undefined)], [id: (id is undefined), label: (label is undefined)]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: browserUseSystemColors, label: Huutoro nooneeji yuɓɓo]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: locationBarSuggestionLabel, label: (label is undefined)]
    accessKey: m found in strings: [id: privacyDoNotTrackPrefs, label: Haalan lowe geese mi yiɗaa rewindeede], [id: historyModeLabel, label: (label is undefined)]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: locationBarSuggestionLabel, label: (label is undefined)]
    accessKey: m found in strings: [id: privacyDoNotTrackPrefs, label: Haalan lowe geese mi yiɗaa rewindeede], [id: historyModeLabel, label: (label is undefined)]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: privateBrowsingAutoStart, label: Huutoro peeragol suturo sahaa kala], [id: showCookiesButton, label: Hollu kukiiji…], [id: locationBarSuggestionLabel, label: (label is undefined)]
    accessKey: m found in strings: [id: privacyDoNotTrackPrefs, label: Haalan lowe geese mi yiɗaa rewindeede], [id: historyModeLabel, label: (label is undefined)]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: privateBrowsingAutoStart, label: Huutoro peeragol suturo sahaa kala], [id: showCookiesButton, label: Hollu kukiiji…], [id: locationBarSuggestionLabel, label: (label is undefined)]
    accessKey: m found in strings: [id: privacyDoNotTrackPrefs, label: Haalan lowe geese mi yiɗaa rewindeede], [id: historyModeLabel, label: (label is undefined)]
    accessKey: f found in strings: [id: blockWebForgeries, label: Falo maawe geese jaŋtaaɗe], [id: showPasswords, label: Danndu Finndeeji…]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: useMasterPassword, label: Huutoro finnde baabaare]
    accessKey: j found in strings: [id: useCursorNavigation, label: Huutoro ŋiiƴe jamngel ngel ngam feeraade e nder kelle], [id: useAutoScroll, label: Huutoro ŋaylogol jaajol], [id: checkDefaultButton, label: Ƴeewto Jooni]
    accessKey: t found in strings: [id: useSmoothScrolling, label: Huutoro ŋaylogol teeyngol], [id: checkSpelling, label: Ƴeewto mbinndiin am so miɗo tappa]
    accessKey: w found in strings: [id: blockAutoRefresh, label: Reentin-am so lowe geese etiima yiiltude walla hesɗitinde hello ngoo], [id: alwaysCheckDefault, label: Ƴeewto sahaa kala ngam yiyde so Aurora ko wanngorde maa woowaande tuma nde hurmiti]
    accessKey: l found in strings: [id: offlineNotify, label: Haalan am so lowre geese naamniima mooftude keɓe ngam huutoreede e ceŋtol], [id: offlineNotifyExceptions, label: Paltooje…]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: systemPref, label: Huutoro proxy yuɓɓo]
    accessKey: h found in strings: [id: (id is undefined), label: Ballal], [id: (id is undefined), label: Hoto yuurnito kesɗitine (wasiyaaka: ena ŋakki hisde)]
    accessKey: i found in strings: [id: (id is undefined), label: Naamno-mi e sahaa kala], [id: viewSecurityDevicesButton, label: Kaɓirɗi Kisal]

Comment 1

6 years ago
Please tell me how to solve this, I will do it as soon as possible.
Thanks

Comment 2

6 years ago
These conflicts are when you have the same accesskey in a form on menu.  If you have for example a form with:

Fil&e
Us&er

You are using the e as an accesskey twice, which is either not ideal or will not work.

The messages in the error report are hard to understand but let me try explain how you can solve them in Pootle:

Taking the last entry:
accessKey: i found in strings: [id: (id is undefined), label: Naamno-mi e sahaa kala], [id: viewSecurityDevicesButton, label: Kaɓirɗi Kisal]

'i' is the accesskey that is used more then once.  It is used in two places.  The id tells us that if the location comment is 'something.label' then we are talking about a something.label and something.accesskey entry.  At least we can search for the text of the label "Naamno-mi e sahaa kala".  This is in conflict with the entry called viewSecurityDevicesButton with the text "Kaɓirɗi Kisal".  To find these you can search for the text found in the label, or you can search for the id.  Just be careful if the id or label text is quite generic.

Please give that a try and if you need further help then we can try assist on the firefox-l10n email list.
(Reporter)

Comment 3

6 years ago
Thanks Dwayne for stepping in here. While we know that the messages are not that perfect it's a good start for us. We will improve those over time and also want to offer screenshots. Sadly those are not fully supported yet by our CI system. Let me try to upload at least one of the failures.

Ibrahima, if you want to run those tests on your own, you can install Mozmill Crowd (https://addons.mozilla.org/en-US/firefox/addon/mozmill-crowd/), and selecting the l10n testrun. Screenshots will then be placed into the selected local crowd folder under the screenshot subdirectory. Those will help you more.
(Reporter)

Comment 4

6 years ago
Can we get any kind of progress on this bug? We receive emails for failures with each check-in for this locale we kinda would like to see stopped. Thanks a lot!
(Reporter)

Comment 5

6 years ago
Created attachment 639746 [details]
screenshots

We would really appreciate if you would fix those reported failures. Most of
the other locales have already been updated regarding those reports and pass
now. I hope the screenshots will help you. Thanks a lot.

Comment 6

6 years ago
Hi,
The screen shots are very useful and I understand the issue and can solve this? But my problem iis I don't know where to find them in Pootle or in Po files.

I tried to use mozmill but it freezes every time. I just want to know where they are located in Pootle.
Regards
(Reporter)

Comment 7

6 years ago
I don't know Pootle and can't really help there. But I think Dwayne can give you all the necessary information how to find those entities. 

On the other side you could query MXR for strings and your locale:

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=Ballal&find=/ff

Comment 8

6 years ago
Ibrahima - the best way is to search for the strings based on the useful info you see in the report.  This might be the text or the location.

Henrik - we're looking at integrating the failure reports into an actual Pootle accessible test.  Until that happens I'm afraid the spam will continue for some locales.

Comment 9

6 years ago
I think I've corrected everything now. Waiting for next checks.
(Reporter)

Comment 10

6 years ago
Looks way better but we still have a lot of access key duplication. Most of some could be newly regressed ones.

http://mozmill-ci.blargon7.com/#/l10n/report/99ab6c49d005522227c5717d8a3c8691

 accessKey: "m" found in: value: So Aurora hurmii:, button#useBookmark
accessKey: "n" found in: checkbox#loadImages, button#colors
accessKey: "m" found in: label#historyModeLabel, label#keepUntil
accessKey: "p" found in: checkbox#rememberForms, button#cookieExceptions
accessKey: "t" found in: checkbox#rememberHistory, checkbox#alwaysClear
accessKey: "d" found in: checkbox#searchStartTyping, button#setDefaultButton
accessKey: "m" found in: checkbox#allowHWAccel, checkbox#checkSpelling
accessKey: "n" found in: checkbox#useCursorNavigation, checkbox#submitCrashesBox
accessKey: "a" found in: radio[label=Aaf kesɗitine e jaajol (ena wasiyaa: kisal ƴellitaama)], button#showUpdateHistory
accessKey: "h" found in: button[label=Ballal], radio[label=Hoto yuurnito kesɗitine (wasiyaaka: ena ŋakki hisde)]
accessKey: "i" found in: radio[label=Naamno-mi e sahaa kala], button#viewSecurityDevicesButton

Comment 11

6 years ago
It is easier if the conflicts are clearly mentioned in pairs or unavailable access keys are mentioned so we don't use them again.
I changed a few "blindly" without knowing what letter could create another confict.
Will try to change letters and report.

Comment 12

6 years ago
Corrected almost eveything. Could not find:

accessKey: "i" found in: radio[label=Naamno-mi e sahaa kala], button#viewSecurityDevicesButton

Please perform another check so I can spot errors
(Reporter)

Comment 13

6 years ago
Ibrahima, please push those updates to http://hg.mozilla.org/releases/l10n/mozilla-aurora/ff/. We only run the l10n tests on this branch. Thanks.

Comment 14

6 years ago
Sorry, I cannot push cause I don't have rights to do so on Pootle: mozilla.locamotion.org.
Dwayne please push those updates when you get a chance. Thanks

Comment 15

6 years ago
(In reply to Ibrahima SARR from comment #14)
> Sorry, I cannot push cause I don't have rights to do so on Pootle:
> mozilla.locamotion.org.
> Dwayne please push those updates when you get a chance. Thanks

Doing this morning.

Henrik -> based on an earlier comment about blind changing.  Is it possible that the report can give us the already used accesskeys.  There is a very real chance that you change an access key and make a new conflict.  So it would be nice to know that abcd are already in use in this context.
(Reporter)

Comment 16

6 years ago
We could do this. Feel free to raise a bug in Mozilla QA / Mozmill tests.

Comment 17

6 years ago
(In reply to Henrik Skupin (:whimboo) from comment #16)
> We could do this. Feel free to raise a bug in Mozilla QA / Mozmill tests.

Bug 774222 raises this issue

Comment 18

6 years ago
Pushed to Mercurial, hopefully this clears this test before it moves from Aurora -> Beta today.
(Reporter)

Comment 19

6 years ago
There are still 2 remaining outstanding issues:
http://mozmill-ci.blargon7.com/#/l10n/report/99ab6c49d005522227c5717d8a54287d

 accessKey: "n" found in: checkbox#useCursorNavigation, checkbox#searchStartTyping, checkbox#submitCrashesBox
accessKey: "i" found in: radio[label=Naamno-mi e sahaa kala], button#viewSecurityDevicesButton

Comment 20

6 years ago
Corrected:  accessKey: "n" found in: checkbox#useCursorNavigation,

Cannot find: accessKey: "i" found in: radio[label=Naamno-mi e sahaa kala],

Comment 21

6 years ago
(In reply to Ibrahima SARR from comment #20)
> Corrected:  accessKey: "n" found in: checkbox#useCursorNavigation,
> 
> Cannot find: accessKey: "i" found in: radio[label=Naamno-mi e sahaa kala],

Search for: certs.ask.accesskey in the locations

Comment 22

6 years ago
Found and corrected.
Sorry did not check "locations" box (disabled by default)... Would have savec time!
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.