Last Comment Bug 757209 - update YSI urls for creating accounts and learning more
: update YSI urls for creating accounts and learning more
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: Thunderbird 15.0
Assigned To: David :Bienvenu
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-21 14:20 PDT by David :Bienvenu
Modified: 2012-05-22 07:13 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
+
fixed


Attachments
proposed fix (1.14 KB, patch)
2012-05-21 14:20 PDT, David :Bienvenu
mconley: review+
Details | Diff | Review

Description David :Bienvenu 2012-05-21 14:20:04 PDT
Created attachment 625760 [details] [diff] [review]
proposed fix

YSI wants us to use

        "https://www.yousendit.com/thunderbird-about-yousendit?s=4001583&cid=pm-4001583" for learn more and "https://www.yousendit.com/litesignup?s=4001583&id=pm-4001583" for needAnAccount.
Comment 1 David :Bienvenu 2012-05-21 14:20:47 PDT
we'll want to land this on aurora and beta asap.
Comment 2 Mike Conley (:mconley) - (Away until June 29th) 2012-05-21 14:29:23 PDT
Comment on attachment 625760 [details] [diff] [review]
proposed fix

Review of attachment 625760 [details] [diff] [review]:
-----------------------------------------------------------------

Besides the & problem, this looks good (though I didn't compile / test it...vacation 'n all. ;) )

-Mike

::: mail/components/cloudfile/content/YouSendIt/settings.xhtml
@@ +19,5 @@
>      <form id="provider-form" onsubmit="return false;">
>        <label for="username">&youSendItSettings.username;</label>
>        <input id="username" type="text" required="true"/>
>        <div id="learn-more" class="float-right">
> +        <a href="https://www.yousendit.com/thunderbird-about-yousendit?s=4001583&amp;cid=pm-4001583">&youSendItSettings.learnMore;</a>

I think the &amp; in the URL is wrong - I think that's supposed to be a pure &.  Same below.
Comment 3 David :Bienvenu 2012-05-21 14:35:22 PDT
heh, if & worked, this would have taken me 2 minutes instead of a couple hours. I needed to use &amp; to get the UI to not get a xml error.

I'll let you be back from vacation to try it out :-) No hurry, just wanted to get the process going...enjoy your day off!
Comment 4 David :Bienvenu 2012-05-22 06:56:30 PDT
fixed on trunk - I'll push to alpha and beta.
Comment 5 David :Bienvenu 2012-05-22 07:13:03 PDT
trunk - http://hg.mozilla.org/comm-central/rev/2e9cb0ffa579
aurora - http://hg.mozilla.org/releases/comm-aurora/rev/9ddcd204a766
beta - http://hg.mozilla.org/releases/comm-beta/rev/7599f7180908

beta didn't apply cleanly, so I had to transplant by hand.

Note You need to log in before you can comment on or make changes to this bug.