Last Comment Bug 757209 - update YSI urls for creating accounts and learning more
: update YSI urls for creating accounts and learning more
Product: Thunderbird
Classification: Client Software
Component: Message Compose Window (show other bugs)
: unspecified
: x86_64 Windows 7
-- normal (vote)
: Thunderbird 15.0
Assigned To: David :Bienvenu
Depends on:
  Show dependency treegraph
Reported: 2012-05-21 14:20 PDT by David :Bienvenu
Modified: 2012-05-22 07:13 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---

proposed fix (1.14 KB, patch)
2012-05-21 14:20 PDT, David :Bienvenu
mconley: review+
Details | Diff | Splinter Review

Description User image David :Bienvenu 2012-05-21 14:20:04 PDT
Created attachment 625760 [details] [diff] [review]
proposed fix

YSI wants us to use

        "" for learn more and "" for needAnAccount.
Comment 1 User image David :Bienvenu 2012-05-21 14:20:47 PDT
we'll want to land this on aurora and beta asap.
Comment 2 User image Mike Conley (:mconley) 2012-05-21 14:29:23 PDT
Comment on attachment 625760 [details] [diff] [review]
proposed fix

Review of attachment 625760 [details] [diff] [review]:

Besides the & problem, this looks good (though I didn't compile / test it...vacation 'n all. ;) )


::: mail/components/cloudfile/content/YouSendIt/settings.xhtml
@@ +19,5 @@
>      <form id="provider-form" onsubmit="return false;">
>        <label for="username">&youSendItSettings.username;</label>
>        <input id="username" type="text" required="true"/>
>        <div id="learn-more" class="float-right">
> +        <a href=";cid=pm-4001583">&youSendItSettings.learnMore;</a>

I think the &amp; in the URL is wrong - I think that's supposed to be a pure &.  Same below.
Comment 3 User image David :Bienvenu 2012-05-21 14:35:22 PDT
heh, if & worked, this would have taken me 2 minutes instead of a couple hours. I needed to use &amp; to get the UI to not get a xml error.

I'll let you be back from vacation to try it out :-) No hurry, just wanted to get the process going...enjoy your day off!
Comment 4 User image David :Bienvenu 2012-05-22 06:56:30 PDT
fixed on trunk - I'll push to alpha and beta.
Comment 5 User image David :Bienvenu 2012-05-22 07:13:03 PDT
trunk -
aurora -
beta -

beta didn't apply cleanly, so I had to transplant by hand.

Note You need to log in before you can comment on or make changes to this bug.