Closed
Bug 757209
Opened 12 years ago
Closed 12 years ago
update YSI urls for creating accounts and learning more
Categories
(Thunderbird :: Message Compose Window, defect)
Tracking
(thunderbird13+ fixed, thunderbird14+ fixed)
RESOLVED
FIXED
Thunderbird 15.0
People
(Reporter: Bienvenu, Assigned: Bienvenu)
Details
Attachments
(1 file)
1.14 KB,
patch
|
mconley
:
review+
|
Details | Diff | Splinter Review |
YSI wants us to use "https://www.yousendit.com/thunderbird-about-yousendit?s=4001583&cid=pm-4001583" for learn more and "https://www.yousendit.com/litesignup?s=4001583&id=pm-4001583" for needAnAccount.
Attachment #625760 -
Flags: review?(mconley)
Assignee | ||
Comment 1•12 years ago
|
||
we'll want to land this on aurora and beta asap.
status-thunderbird13:
--- → affected
status-thunderbird14:
--- → affected
tracking-thunderbird13:
--- → +
tracking-thunderbird14:
--- → +
Comment 2•12 years ago
|
||
Comment on attachment 625760 [details] [diff] [review] proposed fix Review of attachment 625760 [details] [diff] [review]: ----------------------------------------------------------------- Besides the & problem, this looks good (though I didn't compile / test it...vacation 'n all. ;) ) -Mike ::: mail/components/cloudfile/content/YouSendIt/settings.xhtml @@ +19,5 @@ > <form id="provider-form" onsubmit="return false;"> > <label for="username">&youSendItSettings.username;</label> > <input id="username" type="text" required="true"/> > <div id="learn-more" class="float-right"> > + <a href="https://www.yousendit.com/thunderbird-about-yousendit?s=4001583&cid=pm-4001583">&youSendItSettings.learnMore;</a> I think the & in the URL is wrong - I think that's supposed to be a pure &. Same below.
Attachment #625760 -
Flags: review?(mconley) → review+
Assignee | ||
Comment 3•12 years ago
|
||
heh, if & worked, this would have taken me 2 minutes instead of a couple hours. I needed to use & to get the UI to not get a xml error. I'll let you be back from vacation to try it out :-) No hurry, just wanted to get the process going...enjoy your day off!
Assignee | ||
Comment 4•12 years ago
|
||
fixed on trunk - I'll push to alpha and beta.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•12 years ago
|
||
trunk - http://hg.mozilla.org/comm-central/rev/2e9cb0ffa579 aurora - http://hg.mozilla.org/releases/comm-aurora/rev/9ddcd204a766 beta - http://hg.mozilla.org/releases/comm-beta/rev/7599f7180908 beta didn't apply cleanly, so I had to transplant by hand.
Target Milestone: --- → Thunderbird 15.0
You need to log in
before you can comment on or make changes to this bug.
Description
•