75723 - string bundle service needs to use nsCOMPtr

Status: RESOLVED FIXED

(Core :: Internationalization, defect)

Description

[Judson Valeski]

While evaluating users of the std url I found dead use of one in the string 
bundle service. while in the string bundle service I cleaned it up a bit.

- removed unused stdurl (mScratchURI) member var
- comptr'ized interface pointers
- removed layered openInputStream chain of methods
- gave extensible bundle an init method. this is the biggest piece that needs 
reviewing as I changed some more timid error handling into more forceful (exit 
the function) and am not 100% it's right).
- removed extraneous NS_ENSURE_TRUE usage for mProps (we were always doing a 
validation check before calling it)
- removed unused locale arg from CreateExtensibleBundle. the one on CreateBundle 
should go away too (it's not used), but that would be a lot of callsites to 
change.

Comment 1

[Judson Valeski]

Attachment: diffs to clean up string bundles

Comment 2

[Judson Valeski]

alec - sr?
tao  - r?

Comment 3

[Alec Flett]

jud, you rock!
sr=alecf

Comment 4

[tao]

Thanks for cleaning these up. Especially the inputStream() parts and the
deprecated arg, nsILocale. As to the introduced init() method of the 
extensibleBundle, I am for it. Although, I am not the original author of the code,
it looks good. r=tao.

Comment 5

[Judson Valeski]

changes are in. thanks!

Comment 6

[Andreas Becker]

Changing QA Contact to [e-mail].  Can you verify this within
development or provide QA with a test case?  Thanks.