string bundle service needs to use nsCOMPtr

RESOLVED FIXED in mozilla0.9.1

Status

()

Core
Internationalization
RESOLVED FIXED
17 years ago
17 years ago

People

(Reporter: Judson Valeski, Assigned: Judson Valeski)

Tracking

Trunk
mozilla0.9.1
x86
Windows 2000
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

17 years ago
While evaluating users of the std url I found dead use of one in the string 
bundle service. while in the string bundle service I cleaned it up a bit.

- removed unused stdurl (mScratchURI) member var
- comptr'ized interface pointers
- removed layered openInputStream chain of methods
- gave extensible bundle an init method. this is the biggest piece that needs 
reviewing as I changed some more timid error handling into more forceful (exit 
the function) and am not 100% it's right).
- removed extraneous NS_ENSURE_TRUE usage for mProps (we were always doing a 
validation check before calling it)
- removed unused locale arg from CreateExtensibleBundle. the one on CreateBundle 
should go away too (it's not used), but that would be a lot of callsites to 
change.
(Assignee)

Comment 1

17 years ago
Created attachment 30571 [details] [diff] [review]
diffs to clean up string bundles
(Assignee)

Comment 2

17 years ago
alec - sr?
tao  - r?
Keywords: patch
Target Milestone: --- → mozilla0.9.1

Comment 3

17 years ago
jud, you rock!
sr=alecf

Comment 4

17 years ago
Thanks for cleaning these up. Especially the inputStream() parts and the
deprecated arg, nsILocale. As to the introduced init() method of the 
extensibleBundle, I am for it. Although, I am not the original author of the code,
it looks good. r=tao.
(Assignee)

Comment 5

17 years ago
changes are in. thanks!
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 6

17 years ago
Changing QA Contact to ftang@netscape.com.  Can you verify this within
development or provide QA with a test case?  Thanks.
QA Contact: andreasb → ftang
You need to log in before you can comment on or make changes to this bug.