If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[testing] testTransactionExecutor should use the mock module instead

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

5 years ago
The testTransactionExecutor uses ad-hoc MockConnection and MockLogging hacks. Since we bank on the mock module we should use it through out all new code.
(Assignee)

Updated

5 years ago
Assignee: nobody → peterbe
(Assignee)

Comment 1

5 years ago
Pull request up: https://github.com/mozilla/socorro/pull/605

Comment 2

5 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d5430e894e29de1addeb88bd1fc8c54da6109e51
bug757279 - mocking logging with mock instead, r=twobraids
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Comment 3

5 years ago
Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d5430e894e29de1addeb88bd1fc8c54da6109e51
bug757279 - mocking logging with mock instead, r=twobraids

Comment 4

5 years ago
Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7a664f3e58e29ca685f7043e720e97d357ac0f77
bug757279 - mocking logging with mock instead, r=twobraids

Comment 5

5 years ago
Commit pushed to admin-refactor at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d5430e894e29de1addeb88bd1fc8c54da6109e51
bug757279 - mocking logging with mock instead, r=twobraids

Comment 6

5 years ago
Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b9e70c14e06cb60a708ac60314262bb84937027a
bug757279 - mocking logging with mock instead, r=twobraids

Comment 7

5 years ago
Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/b9e70c14e06cb60a708ac60314262bb84937027a
bug757279 - mocking logging with mock instead, r=twobraids
You need to log in before you can comment on or make changes to this bug.