757315 - Link border looks wrong when selecting lightbox

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Will Bamberg [:wbamberg]]

Attachment: screenshot of retronaut lightbox border

Web page or screen you were on when you saw the issue: http://www.retronaut.co/2012/05/searchlights-1940-1945/


Steps to reproduce:
1. Go to http://www.retronaut.co/2012/05/searchlights-1940-1945/
2. Click one of the images to open it in a lightbox
3. Click the lightbox, to move to the next image

A yellow border appears around the lightbox to indicate the clickable area (I guess?) but it extends beyond the lightbox off the screen. I assume this isn't right (it doesn't look right).

I've attached a screenshot.

What you expected: 

Crash report ID (if applicable):

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Reduced test case at http://people.mozilla.org/~kgupta/bug/757315/ - the problem is the text of the link is way off to the left (it has a text-indent: -10000px CSS set on it). We should be able to do better here, by only highlighting the client bounds of the link. I don't know what area actually gets highlighted when we set the state of an element to active.

Comment 2

[Wesley Johnston (:wesj)]

I've thought about setting a solid (non-blurry) box-shadow on these instead of an outline. That works, but because of our non-integer scaling, there's often a tiny gap between the shadow and the background of the box. We could do an inset shadow as well... I start to worry about performance with those tricks. Need a good way to measure it I think.

Comment 3

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.