75735 - pref UI Replace "Netscape" with "Mozilla" or "Navigator" in SSL settings panel

Status: VERIFIED FIXED

(Core Graveyard :: Security: UI, defect, P3)

Description

[Asa Dotzler [:asa]]

Summary:  The SSL settings panel in the new Security preferences has "Netscape
can alert you ...." and "Set Netscape...." description in the SSL Warnings box
(above all the warning checkboxes).  It also has "Decide how Netscape selects a
security certificate..." in the Client Cert Selection box (at the bottom of the
settings for SSL pref panel). Please replace those Netscape mentions with
"Mozilla" or something more generaic.  Thanks.

Comment 1

[André Dahlqvist]

Below is a patch that eliminates the need to use a vendor name by a simple
rewording.

Comment 2

[André Dahlqvist]

Attachment: Patch that removes the use of 'Netscape'

Comment 3

[David P. Drinan]

These strings should go into the .dtd file for PSM. And you can use 
&brandShortName in the dtd to the displayed text browser dependent.

For an example see:
http://lxr.mozilla.org/seamonkey/source/xpfe/components/bookmarks/resources/loca
le/en-US/pref-bookmarks.dtd#10

Comment 4

[André Dahlqvist]

Attachment: Updated patch that modifies pref-security.dtd

Comment 5

[André Dahlqvist]

Attachment: Now the labels are aligned correctly.

Comment 6

[André Dahlqvist]

Attachment: Now they *really* are aligned:-)

Comment 7

[David P. Drinan]

That looks good. Please attach the xul path as well. Thanks.

Comment 8

[David P. Drinan]

The above comment should be "That looks good. Please attach the xul patch as 
well. Thanks."

Comment 9

[HJ]

You might remove those four extra whitespaces between <!ENTITY and there labels.

Comment 10

[André Dahlqvist]

I just realized I've made a misstake. These strings should be added to
pref-ssl.dtd and not pref-security.dtd. I'll attach a new patch soon.

Comment 11

[André Dahlqvist]

Attachment: Patch that changes pref-ssl.dtd and not pref-security.dtd

Comment 12

[André Dahlqvist]

In the .xul-file, do I simply replace the hardcoded string with the labels? If
the label is named certselect.description, do I use &certselect.description in
the .xul-file to access it? I'll attach a patch for pref-ssl.xul once I know this.

Comment 13

[Blake Ross]

&certselect.description;

Comment 14

[Asa Dotzler [:asa]]

Andre, if you can finish this up and get it reviewed we'd take it for 0.9

Comment 15

[André Dahlqvist]

Because of cvs-mirror being down I can't do a cvs diff, so I instead did a local
diff. Do I come even close to the correct solution in the below patch?

Comment 16

[André Dahlqvist]

Attachment: A patch for pref-ssl.xul that uses the labels from the dtd file.

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

looks good. r=[e-mail]

Comment 18

[John Unruh]

Milestone 2.0

Comment 19

[Ben Goodger (use ben at mozilla dot org for email)]

make my r= an sr= ;) 

Comment 20

[Doron Rosenberg (IBM)]

r=doron

Comment 21

[Doron Rosenberg (IBM)]

uh, brand.dtd is not included in the .xul, this will cause errors i believe. 

+<!ENTITY % brandDTD SYSTEM "chrome://global/locale/brand.dtd"> is needed in the
.xul file.

Comment 22

[André Dahlqvist]

Attachment: Updated patch which includes brand.dtd as suggested by doron on IRC.

Comment 23

[Doron Rosenberg (IBM)]

sorry, i was confused

<!DOCTYPE window [
  <!ENTITY % brandDTD SYSTEM "chrome://global/locale/brand.dtd">
  %brandDTD; 
  <!ENTITY % prefSslDTD SYSTEM chrome://pippki/locale/pref-ssl.dtd">
  %prefSslDTD;
]>

is how it should look like.  

Comment 24

[André Dahlqvist]

Attachment: Hopefully the final patch. Follows doron's instructions.

Comment 25

[chris hofmann]

[e-mail] can you make sure commercial build is ok.

a=drivers when ready for 0.9

Comment 26

[Doron Rosenberg (IBM)]

the last patch should do it correct, brand.dtd is included and brandShortName
can be used in the pref-ssl.dtd.  We need a new sr=

r=doron

Comment 27

[André Dahlqvist]

alecf, could you provide a sr= for this one?

Comment 28

[Alec Flett]

sr=alecf

Comment 29

[Brendan Eich [:brendan]]

Who will check in the patch, among reviewers and others who tested and have the
patch working in their tree?  It's approved for 0.9, so someone please get it
checked in.

/be

Comment 30

[André Dahlqvist]

brendan, the two patches have been checked in by [e-mail].

Comment 31

[John G. Myers]

Attachment: Fix typo

Comment 32

[Boris Zbarsky [:bzbarsky]]

hold on.  The pref-ssl.dtd file also had syntax errors in it... attaching a
patch that fixes both.

Comment 33

[Boris Zbarsky [:bzbarsky]]

Attachment: patch fixing various syntax errors so this actually works

Comment 34

[Doron Rosenberg (IBM)]

r=doron, if it's worth anythign by now....

Comment 35

[Boris Zbarsky [:bzbarsky]]

actually, one more problem.  Andre's patch replaced <html> elements with
<label>, killing useful line-wrapping.

Attaching another patch fixing all of the above...

Comment 36

[Boris Zbarsky [:bzbarsky]]

Attachment: fix syntax errors, re-enable wrapping, restore busted wording. Please disregard earlier patches.

Comment 37

[Doron Rosenberg (IBM)]

r=doron remains, we need to fiel a big to make that text shorter though

Comment 38

[Doron Rosenberg (IBM)]

lets try that again, will file a bug on User Interface for a possible shortening
of the text.

Comment 39

[Ben Goodger (use ben at mozilla dot org for email)]

ok, once more, for the money... ;)

sr=ben

Comment 40

[John G. Myers]

Fix checked in.

Comment 41

[André Dahlqvist]

I just verified that this fix is in, and working, with my cvs build from
2001-04-20-10 on Linux. Asa, you can resolve this one as FIXED.

Comment 42

[Gervase Markham [:gerv]]

Wahey :-)

Gerv

Comment 43

[John Unruh]

Verified in the 4/27 WinNT build.