Multiple access keys used in preferences dialog for fy-NL locale

RESOLVED FIXED

Status

Mozilla Localizations
fy-NL / Frisian
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: whimboo, Assigned: Wim)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mozmill-l10n])

Attachments

(1 attachment, 1 obsolete attachment)

Our Mozmill l10n tests have been shown that there are some access keys which are used multiple times in the same scope. The full list of those keys you can find here:

http://mozmill-ci.blargon7.com/#/l10n/report/f87375a634b1a5ba746e5f763a54fe4b

Details:

 accessKey: f found in strings: [id: historyModeLabel, label: (label is undefined)], [id: rememberForms, label: Unthâld syk- en formulierskiednis]
accessKey: h found in strings: [id: (id is undefined), label: Help], [id: rememberHistory, label: Myn navigaasje- en ynlaadskiednis ûnthâlde]
accessKey: p found in strings: [id: useCursorNavigation, label: Hieltyd de pylktoetsen brûke om te navigearjen yn sides], [id: submitTelemetryBox, label: Stoer prestaasjegegevens]
accessKey: s found in strings: [id: showUpdateHistory, label: Fernijingsskiednis sjen litte], [id: enableSearchUpdate, label: Sykmasines]
(Assignee)

Comment 1

6 years ago
Fixed.
Thanks for the report.
Wim
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I still get a failure on OS X:
http://mozmill-ci.blargon7.com/#/l10n/report/fdec829b93b19c73985be1d38833fd2a

accessKey: e found in strings: [id: saveTo, label: Bestannen bewarje yn], [id: chooseFolder, label: Kieze…]
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
The last mentioned access key duplicate has been fixed with:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/987356980fdb

But there is a new one now:
http://mozmill-ci.blargon7.com/#/l10n/report/ee284dfa9d664754a65676abbc0bda0a

accessKey: "l" found in: checkbox#linkTargeting, checkbox#restoreOnDemand
Status: REOPENED → ASSIGNED
(Assignee)

Comment 4

6 years ago
Henrik,
can you point me to the place or file where this happens?
The link above is all gibberish for me.
Wim
Here are both of the locations:

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=restoreOnDemand&find=nl/

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=newWindowsAsTabs.accesskey&find=nl%2F&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora
(Assignee)

Comment 6

6 years ago
Examples are from Dutch (nl) version, but I see what you mean.
This entity should be placed in tabs.dtd I guess, because that is where it shows.
Strangely in my current Aurora it is still in English although it is translated in 
http://mxr.mozilla.org/l10n-mozilla-aurora/source/fy-NL/browser/chrome/browser/preferences/main.dtd#8
Created attachment 637431 [details]
screenshot

Wim, would you have time in the foreseeable future to add this new entity? Attached you can find a screenshot. Thanks.
(Assignee)

Comment 8

6 years ago
Done with the latest translation updates.
Thanks Wim! Looks good again now.
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Looks like some of the failures came back:

http://mozmill-daily.blargon7.com/#/l10n/report/4766c96947f50f00f16d44482a052346

accessKey: "o" found in: radio#dntnopref, label#acceptThirdPartyLabel
accessKey: "t" found in: radio#dntdotrack, button#showCookiesButton
Blocks: 960439
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 11

4 years ago
Fixed in Aurora:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/abf007d87349
and beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/fy-NL/rev/c4df21cbf538

THX
Created attachment 8361579 [details]
screenshot.png

Not sure why but the latest tests still show two failures. See the screenshot.
Attachment #637431 - Attachment is obsolete: true
Btw. this is only for Linux and maybe OS X (which we can't run at the moment). Windows is fine.
(Assignee)

Comment 14

4 years ago
Hopefully now fixed for Aurora in:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/abf007d87349
and beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/fy-NL/rev/c4df21cbf538
There is a single conflict remaining across all platforms, which has been newly introduced with the last landing:

accessKey: "s" found in: label#historyModeLabel, button#showCookiesButton
(Assignee)

Comment 16

4 years ago
Hi Henrik,
yes I see it now, grumbl. I'll try to fix it this afternoon, thanks.
(Assignee)

Comment 17

4 years ago
Another try:
http://hg.mozilla.org/releases/l10n/mozilla-beta/fy-NL/rev/e3004d214c8b
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fy-NL/rev/49f7a9f2d685
Perfect! All duplicated accesskeys are gone. Thanks Wim for fixing that!
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.