757399 - <input type=number> should allow input of floating point number

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Raphael Catolino (:raphc)]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Firefox/15.0a1
Build ID: 20120521030525

Steps to reproduce:

focus a <input type=number>


Actual results:

android numeric keyboard allowing to type decimal number


Expected results:

android keyboard allowing to type decimal number + point

Comment 1

[Raphael Catolino (:raphc)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 626035 [details] [diff] [review]
patch

Raphael - This looks good to me, but I am passing review over to Chris Peterson, who knows more about GeckoInputConnection.java

Comment 3

[Chris Peterson [:cpeterson]]

Comment on attachment 626035 [details] [diff] [review]
patch

Thanks for the patch, Raphael. Your code change looks good to me.

Two suggestions for future patches:

1. You should change your patch's commit message from "r=raphael" to "r=cpeterson" when you check it in. You are the patch author, not the reviewer. <:)

2. When you post a patch for review, you should typically leave the "r=" blank because the reviewer has not granted an r+ yet. You can change the blank "r=" to "r=reviewername" when you commit your r+'d patch to hg.

Comment 4

[Chris Peterson [:cpeterson]]

1. mfinkle, is this <input> fix something you would accept for Aurora? The code change is small, but not a critical bug fix.

2. Assigning bug to Raphael, since he fixed it.

Comment 5

[Raphael Catolino (:raphc)]

Attachment: patch

changed r=cpeterson in comment

Comment 6

[Mounir Lamouri (:mounir)]

Comment on attachment 626078 [details] [diff] [review]
patch

Pushed in mozilla-inbound.

Comment 7

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6e7af2650c

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/dc6e7af2650c