757469 - Implement ctypes.off_t

Status: RESOLVED FIXED

(Core :: js-ctypes, enhancement)

Description

[David Teller [:Yoric] - still alive but not very active]

js-ctypes offers support for size_t and ssize_t, but not for off_t, whose size can generally not be predicted by JS code.

I believe we should add a type ctypes.off_t.

Comment 1

[David Teller [:Yoric] - still alive but not very active]

Attachment: First prototype

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: Implementing ctypes.off_t

Comment 3

[Jason Orendorff [:jorendorff]]

Comment on attachment 626139 [details] [diff] [review]
Implementing ctypes.off_t

>   run_wrapped_integer_tests(library, ctypes.size_t, "size_t", ctypes.size_t.size, false,
>                             ctypes.UInt64, "ctypes.UInt64", ulimits);
>   run_wrapped_integer_tests(library, ctypes.ssize_t, "ssize_t", ctypes.size_t.size, true,
>                             ctypes.Int64, "ctypes.Int64", slimits);
>-  run_wrapped_integer_tests(library, ctypes.uintptr_t, "uintptr_t", ctypes.size_t.size, false,
>-                            ctypes.UInt64, "ctypes.UInt64", ulimits);
>+  run_wrapped_integer_tests(library, ctypes.ssize_t, "ssize_t", ctypes.size_t.size, true,
>+                            ctypes.Int64, "ctypes.Int64", slimits);
>   run_wrapped_integer_tests(library, ctypes.intptr_t, "intptr_t", ctypes.size_t.size, true,
>                             ctypes.Int64, "ctypes.Int64", slimits);

This bit looks like a mistake. r=me with this reverted.

Comment 4

[David Teller [:Yoric] - still alive but not very active]

Attachment: Implementing ctypes.off_t

Fixed, thanks for the quick review.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9f8be665a4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

And backed out for orange.
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d4521e975c8

Try FTW?

https://tbpl.mozilla.org/php/getParsedLog.php?id=12008893&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=12009164&tree=Mozilla-Inbound

Comment 7

[David Teller [:Yoric] - still alive but not very active]

Sorry about that. The error was masked by an intermittent orange.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Attachment: Implementing ctypes.off_t

Here we go. Issue was, as often, not in the code but in the (vastly less documented) test.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6de6c3de450d

Mommy, I'm scared...

Comment 10

[David Teller [:Yoric] - still alive but not very active]

Who wouldn't be?

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6de6c3de450d