75747 - selected item does not appear highlighted when clicked initially in spellchecker

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[shrirang khanzode]

All platforms

Steps:
1 Launch composer
2 Type the text " sote text" ( i meant 'some text')
3 Click on Spellchecker button
4 Spellchecker opens up, in the list titled 'Suggestions' , click on any item 
  with the mouse to select it
5 Observe that the item gets added to the textfield labled 'Change to' but does 
  not appear selected (blue background) even after you clicked on it the first 
  time

Works the second time onwards...

Comment 1

[shrirang khanzode]

by 'click' , I meant 'left click once' 

Comment 2

[kinmoz]

Over to cmanske for investigation. Charley is this an XPFE/skin problem?

Comment 3

[shrirang khanzode]

btw, happens in both skins (mod ,classic)

Comment 4

[Charles Manske]

This is a pain! Setting the contents of the textbox triggers the "oninput"
handler, which unselects the list item. IMHO, that shouldn't happen -- only
user input by typing or pasting should trigger that method.
Chris and David: Is this correct behavior?
We unselect the list when user types because now the selected word in list
probably doesn't correspond.
The fanciest solution would be to search through the list and select an item
if it equals the current textbox contents.

Comment 5

[Charles Manske]

Attachment: Select word in list that matches the input field's value

Comment 6

[Charles Manske]

ready to review

Comment 7

[kinmoz]

+    var wordInList;
+    for (var i = 0; (wordInList=GetTreelistValueAt(dialog.SuggestedList, i)); 
i++)
+    {

Hmmm, using GetTreelistValueAt() as the loop control makes me nervous since it 
returns a string. I know it works, but could we just fetch the length of the 
tree, use the expression (i < length), and move the GetTreelistValueAt() into 
the body of the loop?

sr=[e-mail]

Comment 8

[Charles Manske]

There is no easy way to get number of items in a tree. The tree is a nest of child
nodes: tree->treechildren->treeitem->treerow->treecell, and even if we count
number of treeitems, we'd have to check for the 'label' string, which is always
"" if none exists. It seems very efficient and safe to me.
Simon?

Comment 9

[Charles Manske]

Attachment: Alternate fix that counts number of items in suggested list

Comment 10

[Charles Manske]

I still think first attachment is adequate - I'll let reviews decide.

Comment 11

[Charles Manske]

Attachment: Update on last fix to not abort loop if empty item in middle of list

Comment 12

[Simon Fraser [no longer active]]

sr=sfraser

Comment 13

[Charles Manske]

Latest patch checked in.

Comment 14

[shrirang khanzode]

verif on all 3 builds (0424).