All users were logged out of Bugzilla on October 13th, 2018

Re-enable test for strictness of "newer" parameter.

RESOLVED FIXED

Status

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: rfkelly, Assigned: rfkelly)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa+])

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
As discovered by Bug 744323, the test to check that the "newer" parameter is a strict ">" check is currently disabled.  Note to self to investigate why and to switch it back on post-haste.

Quoting https://github.com/mozilla-services/server-syncstorage/blob/master/syncstorage/tests/functional/test_storage.py#L141:

        res = self.app.get(self.root + '/storage/col2?newer=%s' % ts)
        res = res.json["items"]
        try:
            self.assertEquals(res, ['129'])
        except AssertionError:
            # XXX not sure why this fails sometimes
            pass
(Assignee)

Comment 1

7 years ago
Also, need to add a test for strictness of "older" parameter.
Summary: Re-enable test for exclusivity of "newer" parameter. → Re-enable test for strictness of "newer" parameter.
Something not cleaning itself up properly? Without being able to see what the actual value for res is, that's the most likely culprit behind a heisenbug.
Whiteboard: [qa+]
(Assignee)

Comment 3

7 years ago
Created attachment 626161 [details] [diff] [review]
patch to re-enabled and extend strictness checks

Running the tests in a tight loop as not revealed any spurious failures.  I suspect this was a timing issue of some sort, resolved by adding sleeps and/or improving precision of timestamps.

Attached patch re-enables the test and adds a few more for good measure.  If they start failing again, we'll try to track it down then.
Attachment #626161 - Flags: review?(telliott)
Attachment #626161 - Flags: review?(telliott) → review+
(Assignee)

Comment 4

7 years ago
https://github.com/mozilla-services/server-syncstorage/commit/4e0aca8cab028fd98185c2902d518a0f5fb36f2e
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.