Closed
Bug 757592
Opened 12 years ago
Closed 12 years ago
Re-enable test for strictness of "newer" parameter.
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rfkelly, Assigned: rfkelly)
Details
(Whiteboard: [qa+])
Attachments
(1 file)
1.50 KB,
patch
|
telliott
:
review+
|
Details | Diff | Splinter Review |
As discovered by Bug 744323, the test to check that the "newer" parameter is a strict ">" check is currently disabled. Note to self to investigate why and to switch it back on post-haste. Quoting https://github.com/mozilla-services/server-syncstorage/blob/master/syncstorage/tests/functional/test_storage.py#L141: res = self.app.get(self.root + '/storage/col2?newer=%s' % ts) res = res.json["items"] try: self.assertEquals(res, ['129']) except AssertionError: # XXX not sure why this fails sometimes pass
Assignee | ||
Comment 1•12 years ago
|
||
Also, need to add a test for strictness of "older" parameter.
Summary: Re-enable test for exclusivity of "newer" parameter. → Re-enable test for strictness of "newer" parameter.
Comment 2•12 years ago
|
||
Something not cleaning itself up properly? Without being able to see what the actual value for res is, that's the most likely culprit behind a heisenbug.
Updated•12 years ago
|
Whiteboard: [qa+]
Assignee | ||
Comment 3•12 years ago
|
||
Running the tests in a tight loop as not revealed any spurious failures. I suspect this was a timing issue of some sort, resolved by adding sleeps and/or improving precision of timestamps. Attached patch re-enables the test and adds a few more for good measure. If they start failing again, we'll try to track it down then.
Attachment #626161 -
Flags: review?(telliott)
Updated•12 years ago
|
Attachment #626161 -
Flags: review?(telliott) → review+
Assignee | ||
Comment 4•12 years ago
|
||
https://github.com/mozilla-services/server-syncstorage/commit/4e0aca8cab028fd98185c2902d518a0f5fb36f2e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•1 year ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•