757611 - error: base operand of '->' has non-pointer type AutoFile after bug #307181

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Landry Breuil (:gaston)]

After landing of #307181 build fails on OpenBSD with the following error :

toolkit/mozapps/update/updater/updater.cpp: In function 'int ensure_copy(const char*, const char*)':
toolkit/mozapps/update/updater/updater.cpp:594: error: base operand of '->' has non-pointer type 'AutoFile'

Looking at stdio.h which defines ferror():
 $grep ferr /usr/include/stdio.h            
int      ferror(FILE *);
#define __sferror(p)    (((p)->_flags & __SERR) != 0)
#define ferror(p)       (!__isthreaded ? __sferror(p) : (ferror)(p))

the preprocessed line ends up as :
    if ((!__isthreaded ? (((infile)->_flags & 0x0040) != 0) : (ferror)(infile))) {

which shows that ferror() expects a FILE* and nothing else..

Comment 1

[Landry Breuil (:gaston)]

Attachment: use infile.get() to ensure we pass a FILE*

Comment 2

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfb4508c62aa

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bfb4508c62aa