757625 - The controls should remain visible after seeking if the mouse is over the controls area.

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Paul Adenot (:padenot)]

STR : 
- Open an video, or a page containing a <video>, using the default controls ;
- Start playing ;
- Seek somewhere in the video.

Expected result :
- The controls are still shown until the mouse leaves the control area.

Actual results :
- The controls disappear instantly.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

This is a feature, not a bug. The controls are *supposed* to autohide if there's no movement, except if the mouse is over the controls area.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This bug is specifically about leaving the mouse over the controls after finishing seeking.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Oh oops, I misread Paul's comment 0. Carry on.

Comment 4

[Paul Adenot (:padenot)]

Attachment: Patch v0 : Don't hide the controls if the mouse is over them.

Somehow, |onMouseInOut| is called when the seekbar is clicked, despite being an event on "mouseout". I don't really know if this is expected, but it hides the controls.

Thus, I'm afraid this patch is fixing the consequences, not the cause.

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

To help people who are landing checkin-needed patches, you should update the commit message to have r=jaws :)

Comment 6

[Paul Adenot (:padenot)]

Attachment: Added reviewer name.

I keep forgeting to do that, fixed.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d753a5f4e673

Comment 9

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d753a5f4e673

Comment 10

[Robert Jacobson]

This bug seems to have reappeared ( FF 41.0.2 )
Example video:  http://i.imgur.com/OVdKGFt.gifv 

Same as original problem:

- Start playing ;
- Seek somewhere in the video.

Expected result :
- The controls are still shown until the mouse leaves the control area.

Actual results :
- The controls disappear instantly.

Comment 11

[Robert Jacobson]

Clarification:  The controls disappear on both position seek or resuming from a paused state.  The controls remain visible when using the volume control, pause button, or full-screen button.

Comment 12

[Justin Dolske [:Dolske]]

First - it's better to file a new bug (perhaps referencing an old bug) for new issues. This bug was fixed 4 years ago, so if further work needs done it should be in a new bug. (Because it makes tracking fixes difficult, and it's often a different issue, anyway.)

In this case, it's an issue with imgur. The site disables the default controls by default, and you have to explicitly enable them to see this at all. But the site seems to remove the |controls| attribute whenever various media events fire. EG, just wait for the video to loop back to the beginning, and this happens.

Not an issue with the Firefox video controls.