757647 - Document page-worker's postMessage issue

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: Documentation, defect, P1)

Description

[Will Bamberg [:wbamberg]]

As seen in bug 757612, page-worker's postMessage has a timing issue. This does not occur when using port.emit(), because port.emit() includes a fix.

At least until bug 757612 is fixed, we should document the current issue with postMessage and the fix in port.emit().

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

P1 for if the actual fix can't make it in the same release.

Adding the dependency so we remove the documentation once the fix lands.

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Lets punt on this to 1.9's cycle.

Comment 3

[Will Bamberg [:wbamberg]]

Attachment: document postMessage timing issue

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 640435 [details] [diff] [review]
document postMessage timing issue

Looks good. That's very unfortunate that we have to document such thing :/

We might have to add a new doc section in bug 766088 about worker state.

Comment 5

[Will Bamberg [:wbamberg]]

> We might have to add a new doc section in bug 766088 about worker state.

Do you mean, document the current situation, or document the fix you've proposed there?

Comment 6

[Alexandre Poirot [:ochameau]]

It was just for your information, in case you were not aware of this bug as it is about the same topic: worker state where it is sometime disabled/destroyed.

This patch is totally fine.

We might just end up with a more complete description of worker various states when bug 766088 is going to be fixed.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/e2b154aff5c452d3b4f25bd67513122bd6172319
Bug 757647 - Document page-worker's postMessage issue; r=@ochameau

Comment 8

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2d2a93c0eb127b549464118a658fed1e817a6986
Bug 757647 - Document page-worker's postMessage issue; r=@ochameau
(cherry picked from commit e2b154aff5c452d3b4f25bd67513122bd6172319)

Comment 9

[[github robot]]

Commit pushed to release at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/2d2a93c0eb127b549464118a658fed1e817a6986
Bug 757647 - Document page-worker's postMessage issue; r=@ochameau