"ABORT: Unknown modification type" with mutation observer, SVG transform

RESOLVED FIXED in mozilla15

Status

()

Core
DOM
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Jesse Ruderman, Assigned: smaug)

Tracking

(Blocks: 1 bug, {assertion, testcase})

unspecified
mozilla15
x86_64
Mac OS X
assertion, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 626292 [details]
testcase

###!!! ABORT: Unknown modification type.: 'aModType == nsIDOMMutationEvent::MODIFICATION', file content/svg/content/src/nsSVGGraphicElement.cpp, line 174

I think the problem is that "modType" is used uninitialized in nsGenericElement::SetAttr.
(Reporter)

Comment 1

5 years ago
Created attachment 626293 [details]
stack trace
(Assignee)

Updated

5 years ago
Assignee: nobody → bugs
(Assignee)

Comment 2

5 years ago
Created attachment 626351 [details] [diff] [review]
patch

See http://hg.mozilla.org/mozilla-central/diff/83dce280d871/content/base/src/nsGenericElement.cpp#l1.199
Attachment #626351 - Flags: review?(jonas)
Comment on attachment 626351 [details] [diff] [review]
patch

Review of attachment 626351 [details] [diff] [review]:
-----------------------------------------------------------------

Definitely not related to this bug, but I wonder if it's the right decision to fire mutation observers when an attribute is set to its old value. Last time I measured it was quite common for attributes to be set to a value they already had.

Anyhow, not related to this bug, and if you feel that it's the right thing to fire mutation observers for this situation, then feel free to ignore this comment.
Attachment #626351 - Flags: review?(jonas) → review+
(Assignee)

Comment 4

5 years ago
(In reply to Jonas Sicking (:sicking) from comment #3)
> Comment on attachment 626351 [details] [diff] [review]
> patch
> 
> Review of attachment 626351 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Definitely not related to this bug, but I wonder if it's the right decision
> to fire mutation observers when an attribute is set to its old value. Last
> time I measured it was quite common for attributes to be set to a value they
> already had.
Well, per the current spec, mutationobserver should be fired.
(Assignee)

Comment 5

5 years ago
https://hg.mozilla.org/mozilla-central/rev/0f5089c0daef
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.