Closed Bug 757700 Opened 9 years ago Closed 9 years ago

"ABORT: Unknown modification type" with mutation observer, SVG transform

Categories

(Core :: DOM: Core & HTML, defect)

x86_64
macOS
defect
Not set
critical

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: jruderman, Assigned: smaug)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, testcase)

Attachments

(3 files)

Attached image testcase
###!!! ABORT: Unknown modification type.: 'aModType == nsIDOMMutationEvent::MODIFICATION', file content/svg/content/src/nsSVGGraphicElement.cpp, line 174

I think the problem is that "modType" is used uninitialized in nsGenericElement::SetAttr.
Attached file stack trace
Assignee: nobody → bugs
Comment on attachment 626351 [details] [diff] [review]
patch

Review of attachment 626351 [details] [diff] [review]:
-----------------------------------------------------------------

Definitely not related to this bug, but I wonder if it's the right decision to fire mutation observers when an attribute is set to its old value. Last time I measured it was quite common for attributes to be set to a value they already had.

Anyhow, not related to this bug, and if you feel that it's the right thing to fire mutation observers for this situation, then feel free to ignore this comment.
Attachment #626351 - Flags: review?(jonas) → review+
(In reply to Jonas Sicking (:sicking) from comment #3)
> Comment on attachment 626351 [details] [diff] [review]
> patch
> 
> Review of attachment 626351 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Definitely not related to this bug, but I wonder if it's the right decision
> to fire mutation observers when an attribute is set to its old value. Last
> time I measured it was quite common for attributes to be set to a value they
> already had.
Well, per the current spec, mutationobserver should be fired.
https://hg.mozilla.org/mozilla-central/rev/0f5089c0daef
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.