757700 - "ABORT: Unknown modification type" with mutation observer, SVG transform

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ABORT: Unknown modification type.: 'aModType == nsIDOMMutationEvent::MODIFICATION', file content/svg/content/src/nsSVGGraphicElement.cpp, line 174

I think the problem is that "modType" is used uninitialized in nsGenericElement::SetAttr.

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

See http://hg.mozilla.org/mozilla-central/diff/83dce280d871/content/base/src/nsGenericElement.cpp#l1.199

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 626351 [details] [diff] [review]
patch

Review of attachment 626351 [details] [diff] [review]:
-----------------------------------------------------------------

Definitely not related to this bug, but I wonder if it's the right decision to fire mutation observers when an attribute is set to its old value. Last time I measured it was quite common for attributes to be set to a value they already had.

Anyhow, not related to this bug, and if you feel that it's the right thing to fire mutation observers for this situation, then feel free to ignore this comment.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

(In reply to Jonas Sicking (:sicking) from comment #3)
> Comment on attachment 626351 [details] [diff] [review]
> patch
> 
> Review of attachment 626351 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Definitely not related to this bug, but I wonder if it's the right decision
> to fire mutation observers when an attribute is set to its old value. Last
> time I measured it was quite common for attributes to be set to a value they
> already had.
Well, per the current spec, mutationobserver should be fired.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/0f5089c0daef