Closed Bug 757786 Opened 13 years ago Closed 13 years ago

[gd] No fennec builds due to ' in bookmarks titles

Categories

(Mozilla Localizations :: gd / Scottish Gaelic, defect)

Product:
Mozilla Localizations
Component:
gd / Scottish Gaelic
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Pike, Unassigned)

References

Details

Sadly, bug 756450 keeps builds from succeeding for locales with ' in the titles of bookmarks. We have two alternatives: Wait for a fix for bug 756450. Reword the bookmarks titles 'til that bug is fixed. Note, the bookmarks titles are read on profile creation, so existing users won't get the fixed titles, even if we ship them in an update. As there are no builds, I'm not taking the signoff. Build log excerpt can be seen in bug 756865 comment 4.
I'm slightly confused - which bookmarks are you referring to, the menu item Bookmarks and the menu items below (which don't have any ' in them as far as I can tell) or the included search engines (which don't have any ' in them either).
bookmarks.inc, which is used to give names to the default bookmarks: http://mxr.mozilla.org/l10n-mozilla-aurora/source/gd/mobile/profile/bookmarks.inc#57 has the '
Ah, thank you. If that's the only one holding it up, then we can change that to: Toiseach tòiseachaidh le Firefox I can't make the change myself though.
Ack, sorry, I spoke to soon, it's in the Mobile strings. I'll change it, push and let you know once I've done that.
Changed and pushed. Sorry about the confusion. So I guess we can close this bug as long as I remember not to introduce ' for now and sign off Mobile again?
I'll check the ftp dirs when I do the next review pass. If builds are there, it should be OK. We're still back to flux for the single-locale builds, sadly. chofmann and I are still pushing for it, though.
Michael, can you change that in Pootle also otherwise and update on Pootle will just role over that.
Way ahead of your Dwayne, I did both at the same time :) But thanks for the headsup!
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.