757791 - mozUnlockOrientation() reverts Firefox Android orientation to SENSOR even if auto-rotate has been disabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

mozUnlockOrientation() works in regular web content, steps to reproduce:
- Make sure that you have "Auto-rotate screen" turned off in your Android settings
- Tap on the "unlock screen orientation" button.

Expected result:
- While rotating your phone, the orientation of Fennec should not change

Actual result:
- When rotating the phone, the orientation of Fennec changes

Comment 1

[Tony Chung [:tchung]]

websites shouldnt unlock device orientation in fennec.  it gets stuck in this state even after you exit that page, and wont switch back.

Comment 2

[Mounir Lamouri (:mounir)]

Attachment: Patch

Keep Firefox Android's screen orientation is "unspecified" when unlocking so it will always follow system's settings.

Comment 3

[Mounir Lamouri (:mounir)]

Comment on attachment 635240 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 740190
User impact if declined: when unlockOrientation() will be called, Firefox orientation will be using sensors orientation even if system "auto-rorate" option is disabled.
Risk to taking this patch (and alternatives if risky): very very low; I don't see any.

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/6d2468821b76

Comment 5

[Mounir Lamouri (:mounir)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/00b68de76ba3

Comment 6

[Paul Feher]

Verified/fixed on:
Nightly Fennec 16.0a1 (2012-07-12)
Aurora Fennec 15.0a2 (2012-07-12)
Using:
HTC Desire Z (2.3.3)

While rotating the  phone, the orientation of Fennec isn't changed.