Closed Bug 757818 Opened 13 years ago Closed 13 years ago

Direct entry of some URLs into search box raise error

Categories

(Pancake Graveyard :: Front-end, defect)

Product:
Pancake Graveyard
Component:
Front-end
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: sfoster, Unassigned)

Details

I've seen an error alert typing with some URLs into the search box. Any '%' in the url seems to trigger this. Although we actually prefer '+' to represent space in a querystring, % signs in the query should be valid. Possible dupe of #750668. Note that this same issue occurs in the search-url branch where its supposedly fixed.
This is a funky edge case that mostly hurts developers testing search encoding by keying in different urls into the search box. It turns out to be per-spec behavior for decodeURIComponent - it throws an exception with incomplete input like "something%". We now sanitize input in Url.decodeQueryStringComponent where we're expecting encoded strings by stripping out naked %. Fixed in https://bitbucket.org/mozillapancake/pancake/changeset/4983bbd3cc60
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.