The default bug view has changed. See this FAQ.

Chat UI not correctly hidden on existing profiles

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

13 Branch
Thunderbird 15.0

Thunderbird Tracking Flags

(thunderbird13+ fixed, thunderbird14+ fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
I had a report on IRC that on Tb13b2 with an existing profile the "Tools -> Chat Status" and "Go -> Chat" menu items weren't hidden.

There was this error in the error console:

Error: document.getElementById(aId) is null
Line 683
File: chat-messenger-overlay.js
http://mxr.mozilla.org/comm-beta/source/mail/components/im/content/chat-messenger-overlay.js#683

The same problem didn't happen with a fresh profile.

I suspect for some reason the Chat button wasn't present in the toolbar. A trivial fix seems to just add a null check before attempting to hide an element.
(Assignee)

Updated

5 years ago
tracking-thunderbird13: --- → ?
tracking-thunderbird14: --- → ?
I'm the one that hit this. If I can do anything to assist debugging, just let me know -- I can even package up my profile if that's helpful.
tracking-thunderbird13: ? → +
tracking-thunderbird14: ? → +
(Assignee)

Comment 2

5 years ago
Created attachment 626774 [details] [diff] [review]
Fix

Trivial fix (just adding a null check).

[Approval Request Comment]
This bug is currently quite visible on beta where the Chat feature is pref'ed off, so we need this fix on aurora and beta.

Steps to reproduce on current trunk:
- with Chat enabled (the default on trunk), customize the main toolbar and remove the "Chat" button.
- disable chat (set mail.chat.enabled to false)
- restart
- notice the "document.getElementById(aId) is null" error in the error console, and the "Go -> Chat" and "Tools -> Chat status" aren't hidden.
Assignee: nobody → florian
Attachment #626774 - Flags: review?(mbanner)
Attachment #626774 - Flags: approval-comm-beta?
Attachment #626774 - Flags: approval-comm-aurora?
Attachment #626774 - Flags: review?(mbanner)
Attachment #626774 - Flags: review+
Attachment #626774 - Flags: approval-comm-beta?
Attachment #626774 - Flags: approval-comm-beta+
Attachment #626774 - Flags: approval-comm-aurora?
Attachment #626774 - Flags: approval-comm-aurora+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/comm-central/rev/9c8ea067b3f2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
(Assignee)

Comment 4

5 years ago
https://hg.mozilla.org/releases/comm-aurora/rev/9f435453c7bb
https://hg.mozilla.org/releases/comm-beta/rev/40ca16a22853
status-thunderbird13: --- → fixed
status-thunderbird14: --- → fixed
You need to log in before you can comment on or make changes to this bug.