Last Comment Bug 757845 - Add edge label to write barrier assert
: Add edge label to write barrier assert
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla15
Assigned To: Jan de Mooij [:jandem]
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-23 07:39 PDT by Jan de Mooij [:jandem]
Modified: 2012-05-25 08:24 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.78 KB, patch)
2012-05-23 07:39 PDT, Jan de Mooij [:jandem]
wmccloskey: review+
Details | Diff | Splinter Review

Description Jan de Mooij [:jandem] 2012-05-23 07:39:22 PDT
Created attachment 626432 [details] [diff] [review]
Patch

The IsMarkedOrAllocated(static_cast<Cell *>(thing)) assert is very generic, and this makes it hard for the fuzzers to detect duplicates.

The attached patch attempts to make it less generic by adding the edge label to the write barrier assert, so that the fuzzers can more easily distinguish different bugs.
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-05-25 08:24:40 PDT
https://hg.mozilla.org/mozilla-central/rev/ca00c85ee997

Note You need to log in before you can comment on or make changes to this bug.