Created attachment 626477 [details] [diff] [review] patch, don't use NS_ENSURE_TRUE for normal control flow FT2FontEntry::GetFontTable uses NS_ENSURE_TRUE to return a failure code if the requested table is not present (so FT_Load_Sfnt_Table failed). However, it's perfectly normal for shaping code to request optional tables (such as 'kern' or the OpenType Layout tables); their absence is not an error or anomaly that deserves a warning message. So we should use a simple "if (...) return NS_ERROR_FAILURE" instead of NS_ENSURE_TRUE here, to avoid spamming the console with these warnings.
Comment on attachment 626477 [details] [diff] [review] patch, don't use NS_ENSURE_TRUE for normal control flow This is fine but I don't think the comment is needed.
OK, pushed without added comment. https://hg.mozilla.org/integration/mozilla-inbound/rev/1865549541b7