757879 - Consider removing the concept of latest job of each type

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Ed Morley [:emorley]]

Following on from bug 656732 comment 10.

Bug 656732 is removing the failing job squares from the top right TBPL status panel. This just leaves the tab title and the "N Jobs is/are failing" string that use the concept of the latest job for each type of run. 

If we decided that having the tab title/other string display the total unstarred jobs, and not just of each type, then we could do a fair amount more cleanup.

Comment 1

[Ed Morley [:emorley]]

Sorry, the last sentence should read:

If we decided that having the tab title/other string display the total unstarred jobs, and not just of each type, was acceptable (or even preferable, given it shows how much work the tree needs in terms of starring), then we could do a fair amount more cleanup.

Comment 2

[Ed Morley [:emorley]]

Attachment: Patch v1

Patch for if we go ahead with this. Think I've got everything that can be cleaned out.

Comment 3

[Arpad Borsos [:Swatinem]]

Comment on attachment 627249 [details] [diff] [review]
Patch v1

Review of attachment 627249 [details] [diff] [review]:
-----------------------------------------------------------------

Awesome!
I need to take a deeper look at this myself, maybe i find something as well.
Haven`t been around that code for a while.

::: js/UserInterface.js
@@ +786,5 @@
>        }
>      }
>  
>      $('#status').get(0).innerHTML = (function calcHTML() {
> +      return '<strong>' + failing.length + '</strong> Unstarred';

This should be `unstarred`. You can probably add both failing and unstarred in there.

Comment 4

[Phil Ringnalda (:philor)]

Failing might be interesting if someone wants to write a "display failing when we're displaying a single push" patch, but in general, let's not. I haven't refreshed since I woke up, so my mozilla-inbound tab is displaying 20 or 30 pushes, and I don't have any need whatsoever to be told that that's "120 failing" or "180 failing" or whatever it is.

Comment 5

[Ed Morley [:emorley]]

(In reply to Arpad Borsos (Swatinem) from comment #3)
> This should be `unstarred`.

I capitalised it to match "N Jobs...". I don't really mind either way though...

Comment 6

[Ed Morley [:emorley]]

Ah! You meant use the variable unstarred instead of failing.length, rather than talking about the capitalisation of the string 'unstarred', sorry that makes more sense. (Just realised what you meant after testing locally and spotting that the tab title wasn't matching the number shown in-page).

Landed with that change:
http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/b5e2ef235e55

Comment 7

[Arpad Borsos [:Swatinem]]

Yep that is what i meant. Thanks!