757888 - ENH: Expose 'abort' into XHR and Request modules

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, enhancement, P2)

Description

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

See:  http://pastebin.mozilla.org/1648603 for possible implementation.


Use case: aborting requests.  onComplete is too late.

Comment 1

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

So with that pastebin Gregg linked to applied to my SDK, my simple addon ( http://pastebin.mozilla.org/1648605 ) fires the onComplete function on line 4, logs the response.status as "0", then throws an error about response.json being undefined. 
I'm not really sure if that's what's supposed to happen when you abort() a request ( http://www.w3.org/TR/XMLHttpRequest/#the-abort-method ), but the request clearly doesn't complete. :)

Comment 2

[Gregg Lind (Fx Strategy and Insights - Shield - Heartbeat )]

I certainly wouldn't complain if all the "endings" (ERROR, ABORT, CANCEL) were listenable :)  It seems like the module as written goes to a lot of trouble to hide the xhr request from introspection (during runRequest), which makes Request harder to subclass.  

It would be nice if it was as easy as this:

  var AbortableRequest = Class({
    extends: Request,
    abort:  function(){console.log("aborting"); this.xhr.abort();     this.emit("abort")}
  });

Comment 3

[Andy McKay]

Because of the difficulty finding mentors and the expected life span of the SDK, we are removing [good first bug] from remaining SDK bugs.

Comment 4

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562