9.62 KB, patch
|Details | Diff | Splinter Review|
155.00 KB, image/png
58.07 KB, image/png
In the past, old Fennec build show search-plugins in a line and we have used short name for them to avoid horizontal scroll in the search plugins list. Current Fennec show search plugins as the list item of the awesomebar results vertically. Each search plugin item have enough width and we need not use short name any more. So, let us update the search plugins name. They should be same as desktop builds: http://hg.mozilla.org/releases/l10n/mozilla-release/ja/file/default/browser/searchplugins/ # for example: Amazon -> Amazon.co.jp
Created attachment 626564 [details] [diff] [review] use normal (not short) name for search plugins Please give approval to update the name of search plugins
Attachment #626564 - Flags: review?(stas)
Attachment #626564 - Flags: review?(stas) → review?(l10n)
We want to include this update for NativeUI release. Could you review this or add CC to appropriate person if you cannot decide about this change.
CCing Madhava, I'm seeing a bunch of changes going into our search experience, so I can't really tell if we're changing here for the better.
Created attachment 632577 [details] searchplugins list is shown vertically now As this screen shot show, <ShortName> will be used in the awesome screen itmes which listed vertically with enough width.
Created attachment 632579 [details] searchplugins list was shown in horizontaly in the past This is the screen shot of Fennec Alpha 1 on Mac. # sorry cannot find screenshot like this on Maemo Search plugins are shown in a line and we need avoid to use long string in <ShortName>. That's why it is "Yahoo!", not "Yahoo! JAPAN" like desktop Firefox.
Hi there - This change seems appropriate to me -- we definitely have more room for search provider names in the new layout. There's some chance we might move to columns *on tablets* but there should still be plenty of room.
Attachment #626564 - Flags: review?(madhava) → review+
Comment on attachment 626564 [details] [diff] [review] use normal (not short) name for search plugins Review of attachment 626564 [details] [diff] [review]: ----------------------------------------------------------------- r=me, too, based on Madhava's input.
Attachment #626564 - Flags: review?(l10n) → review+
Thanks! Now fixed: http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/566c02f839f2 http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja-JP-mac/rev/c50835561299 http://hg.mozilla.org/releases/l10n/mozilla-beta/ja/rev/b7d157fc9dcd http://hg.mozilla.org/releases/l10n/mozilla-beta/ja-JP-mac/rev/bfbc750f8642
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.