Stop using short name for search-plugins

RESOLVED FIXED

Status

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bugzilla, Unassigned)

Tracking

({jp-critical})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

6 years ago
In the past, old Fennec build show search-plugins in a line and we have used short name for them to avoid horizontal scroll in the search plugins list.

Current Fennec show search plugins as the list item of the awesomebar results vertically. Each search plugin item have enough width and we need not use short name any more.

So, let us update the search plugins name.
They should be same as desktop builds:
http://hg.mozilla.org/releases/l10n/mozilla-release/ja/file/default/browser/searchplugins/
# for example: Amazon -> Amazon.co.jp
(Reporter)

Comment 1

6 years ago
Created attachment 626564 [details] [diff] [review]
use normal (not short) name for search plugins

Please give approval to update the name of search plugins
Attachment #626564 - Flags: review?(stas)
(Reporter)

Updated

6 years ago
Attachment #626564 - Flags: review?(stas) → review?(l10n)

Updated

6 years ago
Attachment #626564 - Attachment is patch: true
(Reporter)

Comment 2

6 years ago
We want to include this update for NativeUI release.
Could you review this or add CC to appropriate person if you cannot decide about this change.

Updated

6 years ago
Keywords: jp-critical

Comment 3

6 years ago
CCing Madhava, I'm seeing a bunch of changes going into our search experience, so I can't really tell if we're changing here for the better.

Updated

6 years ago
Attachment #626564 - Flags: review?(madhava)
(Reporter)

Comment 4

6 years ago
Created attachment 632577 [details]
searchplugins list is shown vertically now

As this screen shot show, <ShortName> will be used in the awesome screen itmes which listed vertically with enough width.
(Reporter)

Comment 5

6 years ago
Created attachment 632579 [details]
searchplugins list was shown in horizontaly in the past

This is the screen shot of Fennec Alpha 1 on Mac.
# sorry cannot find screenshot like this on Maemo

Search plugins are shown in a line and we need avoid to use long string in <ShortName>. That's why it is "Yahoo!", not "Yahoo! JAPAN" like desktop Firefox.
Hi there -

This change seems appropriate to me -- we definitely have more room for search provider names in the new layout. There's some chance we might move to columns *on tablets* but there should still be plenty of room.
Attachment #626564 - Flags: review?(madhava) → review+

Comment 7

6 years ago
Comment on attachment 626564 [details] [diff] [review]
use normal (not short) name for search plugins

Review of attachment 626564 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, too, based on Madhava's input.
Attachment #626564 - Flags: review?(l10n) → review+
You need to log in before you can comment on or make changes to this bug.