758158 - make sample_config.tmpl a template or get rid of it

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Jeff Hammel]

For bug 704654 I left in a copy of the legacy sample.config as
http://hg.mozilla.org/build/talos/file/2339d6217ae1/talos/sample_config.tmpl
with the idea of making this into a template, so instead of doing
yaml.dump() to serialize configuration, we can write to a more
organized template.

This isn't particularly hard to do (although it may be annoying), but
do we care?  If not we can just remove the file and close this bug

Comment 1

[Jeff Hammel]

Attachment: just remove it

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 682215 [details] [diff] [review]
just remove it

Review of attachment 682215 [details] [diff] [review]:
-----------------------------------------------------------------

do we have buildbot configs that use this?  I don't think we do for m-c based builds.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

I see sample.2.config, xperf.config, remote.config being referenced in buildbot-configs/mozilla-test/config.py.

Comment 4

[Jeff Hammel]

(In reply to Joel Maher (:jmaher) from comment #2)
> Comment on attachment 682215 [details] [diff] [review]
> just remove it
> 
> Review of attachment 682215 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> do we have buildbot configs that use this?  I don't think we do for m-c
> based builds.

AFAIK and as far as http://k0s.org:8080/ knows, no.  Should I test (somehow?) or just check in?

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

lets just check it in!

Comment 6

[Jeff Hammel]

pushed: http://hg.mozilla.org/build/talos/rev/dd233ce3268f