758226 - Clean up IME states and ensure we respond correctly

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

The IMEState struct has two fields that together are supposed to represent the IME opened/closed state. In nsWindow::SetInputContext, we really only look at IMEState.mEnabled, but that's not really correct. The value of mOpen should be considered as well, but exactly how that should be done is pretty unclear. For instance, we seem to get mEnabled = DISABLED and mOpen = OPEN sometimes.

For plugins, we get mEnabled = PLUGIN, mOpen = OPEN_STATE_NOT_SUPPORTED whenever a plugin is focused. Flash can then explicitly request the vkb be opened or closed, and in that case we set mOpen to OPEN or CLOSED as appropriate.

Comment 1

[Chris Peterson [:cpeterson]]

This comment in nsIContent.h:

https://hg.mozilla.org/mozilla-central/file/2552b0541f87/content/base/public/nsIContent.h#l580

says IMEState should never have set (DISABLED and (OPEN or CLOSED)), which implies (DISABLED and OPEN_STATE_NOT_SUPPORTED) is the only valid DISABLED state.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.