758241 - enable harfbuzz text shaping for all scripts on Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Jonathan Kew [:jfkthame]]

Attachment: patch, turn on harfbuzz for all scripts on Android

Given that we currently have *no* shaping for Indic scripts on Android, I think that once we update our harfbuzz version in bug 758236, it'd make sense to simply enable harfbuzz for all scripts on this platform.

It will have adequate support for some of the Indic scripts - Devanagari and Gujarati are in particularly good shape, while some of the South Indian scripts still have known problems, though they'll be closer to correct than they are at present with the "no-shaping" FT2Fonts backend.

Comment 1

[John Daggett (:jtd)]

Even if reftests are not run on Android, I'd like to have at least a few rudimentary Indic reftests in place before enabling this, at least so that someone can manually verify regressions that occur in the future.

Comment 2

[Jonathan Kew [:jfkthame]]

Bug 758236 now includes some basic reftests for Indic shaping behavior.

Comment 3

[John Daggett (:jtd)]

Comment on attachment 626842 [details] [diff] [review]
patch, turn on harfbuzz for all scripts on Android

Add a comment line to say something like "scripts not listed are grouped in the default category".

Comment 4

[Jet Villegas (inactive)]

Nomming this for Fennec blocker status. We need this to support Indic scripts on Mobile.

Comment 5

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4a05850be02

Comment 6

[Joe Drew (not getting mail)]

Given that this (apparently) requires a harfbuzz update to be useful, we're just going to let this ride the trains.

Comment 7

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/b4a05850be02