758257 - Arabic joining on bbcpersian.com broken if the tab is restored after Fennec loads

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[(no longer active)]

I've noticed this on Aurora and I think on Nightly as well.  When I load bbcpersian.com from scratch after opening firefox it displays the text fine, but when a tab is restored when firefox starts up, parts of the text on the page still appears non-joined.

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: patch, work around broken fonts on android when using cached font list as well as when first reading the list

I believe the problem is that the workaround in bug 706888 was only applied when initially reading the list of fonts from the filesystem, but doesn't take effect when loading the font list from the startupcache - therefore, the bug doesn't appear on first run after install/update, but does appear on subsequent launches.

This ought to fix it, by factoring out the bad-font workarounds and applying the same hacks to both the freshly-loaded and cached font lists.

Not yet tested, but tryserver build should appear at https://tbpl.mozilla.org/?tree=Try&rev=dfe27063b675 shortly if all goes well.

Comment 2

[(no longer active)]

Your theory makes a lot of sense to me.

Comment 3

[Jonathan Kew [:jfkthame]]

Tryserver decided not to bother doing anything with that push :( so I've pushed it again, hope to get a result this time:
https://tbpl.mozilla.org/?tree=Try&rev=93890f7f6887

Comment 4

[John Daggett (:jtd)]

Comment on attachment 626987 [details] [diff] [review]
patch, work around broken fonts on android when using cached font list as well as when first reading the list

Looks fine.  I still hate having to do these evil per-font hacks but that's life I guess.

Comment 5

[(no longer active)]

I tried the try server build here, and it does indeed fix the bug.

Comment 6

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1585459db40a

Comment 7

[Jonathan Kew [:jfkthame]]

Comment on attachment 626987 [details] [diff] [review]
patch, work around broken fonts on android when using cached font list as well as when first reading the list

[Approval Request Comment]
Bug caused by (feature/regressing bug #): fix in bug 706888 was incomplete, because we have two distinct code paths for building the font list (directly, or from startup-cache)

User impact if declined: broken Arabic-script text on some devices

Testing completed (on m-c, etc.): Ehsan confirmed tryserver build with patch fixes the bug on his affected device

Risk to taking this patch (and alternatives if risky): minimal risk - mobile-only, narrowly targeted fix for broken font; patch just factors out the fix from 706888 so that both font-list codepaths can use it

String or UUID changes made by this patch: none

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1585459db40a

Comment 9

[Joe Drew (not getting mail)]

Comment on attachment 626987 [details] [diff] [review]
patch, work around broken fonts on android when using cached font list as well as when first reading the list

Please land ASAP for the Fennec beta build.

Comment 10

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/d490cc85303c

Comment 11

[(no longer active)]

Jonathan, did this get stuck on Aurora?  I still see the bug there...

Comment 12

[Jonathan Kew [:jfkthame]]

AFAIK, this should be on Aurora - could you double-check exactly what build you're using and confirm the steps that reproduce the bug? Is it still happening when restoring tabs?

Comment 13

[(no longer active)]

I'm using the latest Aurora nightly.  Now Arabic joining seems to be completely broken for some fonts, no matter when the tabs are restored or when you navigate to them from scratch.

Nightly seems to work just fine though...

Comment 14

[Jonathan Kew [:jfkthame]]

It sounds like you may be seeing yet another issue, then (sigh).... could you give a specific URL that shows the problem, along with a screenshot of the result you see?

Comment 15

[(no longer active)]

bbcpersian.com, will attach the screenshot in a sec.

Comment 16

[(no longer active)]

Attachment: screenshot on aurora

Comment 17

[(no longer active)]

Comment on attachment 629869 [details]
screenshot on aurora

The text of the news articles appears to always join properly, but the headline font on the article pages is not joined.  This bug however manifests itself on the homepage much better though, as seen here.

Comment 18

[Jonathan Kew [:jfkthame]]

Sorry, I'm at a loss here.... AFAICS, the same Arabic-font fixes are present in both Aurora and Nightly. I can't reproduce the issue locally, as I don't have a device that suffers from the broken-DroidSansArabic problem.

Comment 19

[Kartikaya Gupta (email:[e-mail])]

Ehsan, which build are you running?

Comment 20

[(no longer active)]

I'm running Aurora nightly from 2012-06-04 (according to about:firefox).

Any chance you can install the fonts I attached to bug 706888 and see if you can reproduce this?

Comment 21

[Andreea Pod]

The text including the headline is joined.

I verified this on: LG Optimus 2X (Android 2.2.2)
Builds:
- Nightly 16.0a1 (2012-06-06)
- Aurora 15.0a2 (2012-06-06)
- Firefox 14.0 Beta 6 (2012-06-06)

Marking it as verified fixed, please reopen if you still can see the bug.