NPN_PostUrl(Notify) doesn't work if streaming from file

VERIFIED FIXED in mozilla0.9

Status

()

Core
Plug-ins
P2
normal
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: av (gone), Assigned: av (gone))

Tracking

Trunk
mozilla0.9
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: eta -- 4.17.01)

Attachments

(2 attachments)

(Assignee)

Description

17 years ago
nsPluginHostImpl::PostUrl ignores boolean aIsFile input parameter. This causes 
NPN_PostUrl failure in case when the stream is supposed to come from file.
(Assignee)

Updated

17 years ago
Blocks: 53347
(Assignee)

Comment 1

17 years ago
Nominating for 0.9 as it blocks Acrobat forms issue.
Priority: -- → P2
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 2

17 years ago
Created attachment 30864 [details] [diff] [review]
first try
(Assignee)

Comment 3

17 years ago
Peter, would you please review?

Comment 4

17 years ago
Few questions:

1) Why the removal of:
-  // nsIProgressEventSink methods:
-  // nsIRequestObserver methods:
-  // nsIStreamListener methods:

2) The "file://" stuff makes me wery. Isn't there some interface methond that 
does for nsIFiles?

3) I'd like to try on Mac and Linux on Monday.
(Assignee)

Comment 5

17 years ago
> 1) Why the removal of:

Just looks better. The same wording is in the names of the macros themselves. No 
loss of information.

> 2) The "file://" stuff makes me wery. Isn't there some interface methond that 
does for nsIFiles?

I'll try to search more.

About the file to delete... I am also thinking of keeping just its path rather 
than nsILocalFile object and create nsILocalFile only at the point we want to 
delete it. Should be slightly better for footprint.
(Assignee)

Comment 6

17 years ago
Created attachment 30949 [details] [diff] [review]
second try -- storing only a path of the tmp file rather than nsILocalFile object

Comment 7

17 years ago
r=peterl

Comment 8

17 years ago
rs=waterson
(Assignee)

Updated

17 years ago
Whiteboard: eta -- 4.17.01
(Assignee)

Comment 9

17 years ago
Checked in. Marking fixed.
(Assignee)

Comment 10

17 years ago
Forgot to mark, as usual. Marking.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 11

17 years ago
verif (stamp)
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.