75826 - NPN_PostUrl(Notify) doesn't work if streaming from file

Status: VERIFIED FIXED

(Core Graveyard :: Plug-ins, defect, P2)

Description

[av (gone)]

nsPluginHostImpl::PostUrl ignores boolean aIsFile input parameter. This causes 
NPN_PostUrl failure in case when the stream is supposed to come from file.

Comment 1

[av (gone)]

Nominating for 0.9 as it blocks Acrobat forms issue.

Comment 2

[av (gone)]

Attachment: first try

Comment 3

[av (gone)]

Peter, would you please review?

Comment 4

[Peter Lubczynski]

Few questions:

1) Why the removal of:
-  // nsIProgressEventSink methods:
-  // nsIRequestObserver methods:
-  // nsIStreamListener methods:

2) The "file://" stuff makes me wery. Isn't there some interface methond that 
does for nsIFiles?

3) I'd like to try on Mac and Linux on Monday.

Comment 5

[av (gone)]

> 1) Why the removal of:

Just looks better. The same wording is in the names of the macros themselves. No 
loss of information.

> 2) The "file://" stuff makes me wery. Isn't there some interface methond that 
does for nsIFiles?

I'll try to search more.

About the file to delete... I am also thinking of keeping just its path rather 
than nsILocalFile object and create nsILocalFile only at the point we want to 
delete it. Should be slightly better for footprint.

Comment 6

[av (gone)]

Attachment: second try -- storing only a path of the tmp file rather than nsILocalFile object

Comment 7

[Peter Lubczynski]

r=peterl

Comment 8

[Chris Waterson]

rs=waterson

Comment 9

[av (gone)]

Checked in. Marking fixed.

Comment 10

[av (gone)]

Forgot to mark, as usual. Marking.

Comment 11

[shrirang khanzode]

verif (stamp)