758301 - Media resources can consume all the user's disk space due to use of STORE_ON_DISK_AS_FILE

Status: RESOLVED WORKSFORME

(Core :: Audio/Video: Playback, defect)

Description

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

+++ This bug was initially created as a clone of Bug #725993 +++

See also bug 758296 (for XHR). Because ChannelMediaResource::OnStartRequest uses the STORE_ON_DISK_AS_FILE mechanism, we do not enforce any kind of maximum size constraint on the resource. As a result, an extremely large video can be used to consume all the user's disk space, which can be difficult or in some cases maybe impossible to recover from, as some operating systems do not handle running out of disk space in any reasonable way.

Because the implementation of STORE_ON_DISK_AS_FILE apparently does main thread I/O, this is also a snappiness issue. (According to Michal, Media's use of STORE_ON_DISK_AS_FILE is the main cause of STORE_ON_DISK_AS_FILE-related jank.)

Part of the patch in bug 725993 removes the usage of STORE_ON_DISK_AS_FILE here, but I don't know if that is an acceptable solution.

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

I'm happy with just removing STORE_ON_DISK_AS_FILE there.

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Michal, since you already wrote the patch in bug 725993 to remove STORE_ON_DISK_AS_FILE, I am marking this as assigned to you.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Is this fixed?

Comment 4

[Michal Novotny [:michal]]

This is no longer issue in the new cache (even in the old cache it has been fixed long time ago).