Last Comment Bug 758478 - TestMailCookie is linked with C compiler instead of C++ compiler
: TestMailCookie is linked with C compiler instead of C++ compiler
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Build Config (show other bugs)
: Trunk
: x86 Solaris
: -- normal (vote)
: Thunderbird 16.0
Assigned To: Ginn Chen
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-05-24 18:36 PDT by Ginn Chen
Modified: 2012-06-04 19:12 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
patch (533 bytes, patch)
2012-05-24 18:38 PDT, Ginn Chen
standard8: review-
Details | Diff | Splinter Review
patch v2 (838 bytes, patch)
2012-05-31 18:16 PDT, Ginn Chen
standard8: review+
Details | Diff | Splinter Review

Description Ginn Chen 2012-05-24 18:36:29 PDT
Because the Makefile.in only has SIMPLE_PROGRAMS=TestMailCookie$(BIN_SUFFIX), C compiler is used as linker.

The file uses C++ libraries, so it will fail on linking.

Add CPPSRCS will solve the problem.
Comment 1 Ginn Chen 2012-05-24 18:38:00 PDT
Created attachment 627063 [details] [diff] [review]
patch
Comment 2 Mark Banner (:standard8, afk until Dec) 2012-05-26 12:37:10 PDT
Could using CPP_UNIT_TESTS work better?
Comment 3 Mark Banner (:standard8, afk until Dec) 2012-05-31 07:01:02 PDT
Comment on attachment 627063 [details] [diff] [review]
patch

Looking at http://hg.mozilla.org/comm-central/annotate/5aa8ecd0c99a/config/rules.mk#l142 I think we should be able to use CPP_UNIT_TESTS here and we can possibly clean up some of the other definitions in this makefile as well.
Comment 4 Ginn Chen 2012-05-31 18:16:20 PDT
Created attachment 629018 [details] [diff] [review]
patch v2
Comment 5 Mark Banner (:standard8, afk until Dec) 2012-06-04 04:51:52 PDT
Comment on attachment 629018 [details] [diff] [review]
patch v2

Looks good, thanks.

Note You need to log in before you can comment on or make changes to this bug.