TestMailCookie is linked with C compiler instead of C++ compiler

RESOLVED FIXED in Thunderbird 16.0

Status

Thunderbird
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

Trunk
Thunderbird 16.0
x86
Solaris

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

838 bytes, patch
standard8
: review+
Details | Diff | Splinter Review
(Assignee)

Description

5 years ago
Because the Makefile.in only has SIMPLE_PROGRAMS=TestMailCookie$(BIN_SUFFIX), C compiler is used as linker.

The file uses C++ libraries, so it will fail on linking.

Add CPPSRCS will solve the problem.
(Assignee)

Comment 1

5 years ago
Created attachment 627063 [details] [diff] [review]
patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627063 - Flags: review?
(Assignee)

Updated

5 years ago
Attachment #627063 - Flags: review? → review?(mbanner)
Could using CPP_UNIT_TESTS work better?
Comment on attachment 627063 [details] [diff] [review]
patch

Looking at http://hg.mozilla.org/comm-central/annotate/5aa8ecd0c99a/config/rules.mk#l142 I think we should be able to use CPP_UNIT_TESTS here and we can possibly clean up some of the other definitions in this makefile as well.
Attachment #627063 - Flags: review?(mbanner) → review-
(Assignee)

Comment 4

5 years ago
Created attachment 629018 [details] [diff] [review]
patch v2
Attachment #627063 - Attachment is obsolete: true
Attachment #629018 - Flags: review?(mbanner)
Comment on attachment 629018 [details] [diff] [review]
patch v2

Looks good, thanks.
Attachment #629018 - Flags: review?(mbanner) → review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/comm-central/rev/7588fecccb05
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 16.0
You need to log in before you can comment on or make changes to this bug.