758480 - Missing daily stats should be listed as 0 in graph/JSON

Status: VERIFIED FIXED

(Marketplace Graveyard :: Statistics, defect, P3)

Description

[Christopher Van Wiemeersch [:cvan]]

Attachment: Empty data

Because the JSON is being generated from whatever we have in Installed.search() we're not filling in the gaps for missing dates:

https://marketplace-dev.allizom.org/en-US/app/seevans-underworld-adventur/statistics/installs-day-20120225-20120525.json

[
    ...,
    {
        "date": "2012-04-16",
        "count": 13,
        "end": "2012-04-16"
    },
    {
        "date": "2012-04-15",
        "count": 1,
        "end": "2012-04-15"
    },
    {
        "date": "2012-04-13",
        "count": 15,
        "end": "2012-04-13"
    },
    ...
]

(See attached image for clarification. Incidentally, it looks like the graph is not matching the install counts in the table.)

Expected result:
(Case 1) If you have no data for the entire range, return nothing. For example:

   April 14: no data
   April 15: no data
   April 16: no data

The JSON feed should be empty: []

(Case 2) If you have any missing days for a date range, assume those gaps had 0 installs. For example:

   April 13: 15
   April 14: no data
   April 15: 1
   April 16: 6

The JSON feed should return this:

[
    {
        "date": "2012-04-16",
        "count": 13,
        "end": "2012-04-16"
    },
    {
        "date": "2012-04-15",
        "count": 1,
        "end": "2012-04-15"
    },
    {
        "date": "2012-04-14",
        "count": 0,
        "end": "2012-04-13"
    },
    {
        "date": "2012-04-13",
        "count": 15,
        "end": "2012-04-13"
    },
]

Comment 1

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/d220b40e7506a7143b5bb8aca9531152e8a51937

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Is there any way we can get the items to be in chronological order:

[
...
{
    "date": "2012-04-06",
    "count": 0,
    "end": "2012-04-06"
},
{
    "date": "2012-04-14",
    "count": 0,
    "end": "2012-04-14"
},
{
    "date": "2012-04-22",
    "count": 0,
    "end": "2012-04-22"
},
...
]

Comment 3

[Kevin Ngo [:ngoke]]

(In reply to Chris Van Wiemeersch [:cvan] from comment #2)
> Is there any way we can get the items to be in chronological order:
> 
> [
> ...
> {
>     "date": "2012-04-06",
>     "count": 0,
>     "end": "2012-04-06"
> },
> {
>     "date": "2012-04-14",
>     "count": 0,
>     "end": "2012-04-14"
> },
> {
>     "date": "2012-04-22",
>     "count": 0,
>     "end": "2012-04-22"
> },
> ...
> ]

Crap...I had it like that before I modularized it :(

Comment 5

[Kevin Ngo [:ngoke]]

https://github.com/mozilla/zamboni/commit/02d92bc92a3e8e193d84c8b78deafb64cc977a08

Comment 6

[Victor Carciu]

Verified as fixed.

Comment 7

[Victor Carciu]

Attachment: Postfix Screenshot