consistently use typedef for NS_tchar

RESOLVED FIXED in mozilla15

Status

()

Toolkit
Application Update
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ginn Chen, Assigned: Ginn Chen)

Tracking

unspecified
mozilla15
x86
Solaris
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
/toolkit/mozapps/update/updater/archivereader.h uses #define for NS_tchar

it caused a problem:

updater/updater.cpp
sees
void UpdateLog::Init(char* sourcePath, const char* fileName,
                     const char* alternateFileName, bool append);

common/updatelogging.cpp
sees
typedef char NS_tchar;
void UpdateLog::Init(NS_tchar* sourcePath, const NS_tchar* fileName,
                     const NS_tchar* alternateFileName, bool append);

They may have different mangled name so it may fails on linking.
(Assignee)

Comment 1

6 years ago
Created attachment 627109 [details] [diff] [review]
patch

also turn on testing for Solaris.
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627109 - Flags: review?(robert.bugzilla)
Attachment #627109 - Flags: review?(robert.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/7944fff56dc8
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.