Closed Bug 758514 Opened 9 years ago Closed 9 years ago

consistently use typedef for NS_tchar

Categories

(Toolkit :: Application Update, defect)

x86
Solaris
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: ginnchen+exoracle, Assigned: ginnchen+exoracle)

Details

Attachments

(1 file)

1.26 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review
/toolkit/mozapps/update/updater/archivereader.h uses #define for NS_tchar

it caused a problem:

updater/updater.cpp
sees
void UpdateLog::Init(char* sourcePath, const char* fileName,
                     const char* alternateFileName, bool append);

common/updatelogging.cpp
sees
typedef char NS_tchar;
void UpdateLog::Init(NS_tchar* sourcePath, const NS_tchar* fileName,
                     const NS_tchar* alternateFileName, bool append);

They may have different mangled name so it may fails on linking.
Attached patch patchSplinter Review
also turn on testing for Solaris.
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #627109 - Flags: review?(robert.bugzilla)
Attachment #627109 - Flags: review?(robert.bugzilla) → review+
https://hg.mozilla.org/mozilla-central/rev/7944fff56dc8
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.