Closed
Bug 758575
Opened 9 years ago
Closed 9 years ago
Port |Bug 636402 - Simplify Sync.js to avoid creating new objects| to SeaMonkey
Categories
(SeaMonkey :: Build Config, defect, P4)
SeaMonkey
Build Config
Tracking
(seamonkey2.9 wontfix, seamonkey2.10 wontfix, seamonkey2.11 fixed, seamonkey2.12 fixed)
RESOLVED
FIXED
seamonkey2.13
People
(Reporter: sgautherie, Assigned: sgautherie)
References
Details
Attachments
(1 file)
1.44 KB,
patch
|
Callek
:
review+
Callek
:
approval-comm-aurora+
Callek
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
No description provided.
Flags: in-testsuite-
Assignee | ||
Comment 1•9 years ago
|
||
Attachment #627185 -
Flags: review?(bugspam.Callek)
Attachment #627185 -
Flags: approval-comm-beta?
Attachment #627185 -
Flags: approval-comm-aurora?
Assignee | ||
Updated•9 years ago
|
Comment 2•9 years ago
|
||
Comment on attachment 627185 [details] [diff] [review] (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects| [Checked in: Comment 4 & 8] It is inside the omnijar ifdef for Firefox, is it needed outside (especially for branches)?
Attachment #627185 -
Flags: approval-comm-beta?
Attachment #627185 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 3•9 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #2) > It is inside the omnijar ifdef for Firefox, Because, as often, they missed to update its removed-files.in. > is it needed outside (especially for branches)? Yes: Sync.js was removed from the tree. Yes: that removal happened in 2011.02...
Updated•9 years ago
|
Attachment #627185 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Updated•9 years ago
|
Attachment #627185 -
Flags: approval-comm-beta?
Attachment #627185 -
Flags: approval-comm-aurora?
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 627185 [details] [diff] [review] (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects| [Checked in: Comment 4 & 8] http://hg.mozilla.org/comm-central/rev/e7798995bdc5
Attachment #627185 -
Attachment description: (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects| → (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects|
[Checked in: Comment 4]
Assignee | ||
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
status-seamonkey2.12:
--- → affected
Resolution: --- → FIXED
Target Milestone: seamonkey2.12 → seamonkey2.13
Updated•9 years ago
|
Attachment #627185 -
Flags: approval-comm-beta?
Attachment #627185 -
Flags: approval-comm-beta+
Attachment #627185 -
Flags: approval-comm-aurora?
Attachment #627185 -
Flags: approval-comm-aurora+
Comment 5•9 years ago
|
||
There is a list of bugs I just approved for beta (though we're on our last beta now, with the release spinning friday or sat) which touch this same file (removed-files.in) This is one of those bugs where I could not find a way to apply it to beta, even after mixing and matching the order here repeatedly. Please either provide one monolithic patch which makes someones life easier, convince someone to untangle, tell us the order, or do it yourself. Otherwise I am comfortable with these slipping from this release. I won't even attempt to land these patches on aurora for the same reasons without one of the above solutions being done.
Assignee | ||
Comment 6•9 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #4) > http://hg.mozilla.org/comm-central/rev/e7798995bdc5 (In reply to Justin Wood (:Callek) from comment #5) > tell us the order Please c-n the 6 changesets in http://hg.mozilla.org/comm-central/pushloghtml?changeset=e7798995bdc5
Keywords: checkin-needed
Whiteboard: [c-n: comment 6 to c-a and c-b]
Comment 7•9 years ago
|
||
Seriously, roll-up patches wouldn't kill you... https://hg.mozilla.org/releases/comm-aurora/rev/e23aee37d526 https://hg.mozilla.org/releases/comm-aurora/rev/2f8b759d8f67 https://hg.mozilla.org/releases/comm-aurora/rev/a861f61eb3bb https://hg.mozilla.org/releases/comm-aurora/rev/3bec5d7aac5a https://hg.mozilla.org/releases/comm-aurora/rev/105b9574b63d https://hg.mozilla.org/releases/comm-aurora/rev/da40e0e9a33b https://hg.mozilla.org/releases/comm-beta/rev/7b59567495cf https://hg.mozilla.org/releases/comm-beta/rev/fb395b70bc9a https://hg.mozilla.org/releases/comm-beta/rev/54e677193947 https://hg.mozilla.org/releases/comm-beta/rev/10c4ab8c6f41 https://hg.mozilla.org/releases/comm-beta/rev/72f823ea4cf7 https://hg.mozilla.org/releases/comm-beta/rev/65bfeec082e7
Keywords: checkin-needed
Whiteboard: [c-n: comment 6 to c-a and c-b]
Assignee | ||
Comment 8•9 years ago
|
||
Comment on attachment 627185 [details] [diff] [review] (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects| [Checked in: Comment 4 & 8] (In reply to Ryan VanderMeulen from comment #7) > Seriously, roll-up patches wouldn't kill you... Noted. > https://hg.mozilla.org/releases/comm-aurora/rev/e23aee37d526 > > https://hg.mozilla.org/releases/comm-beta/rev/7b59567495cf These are the changesets for this bug.
Attachment #627185 -
Attachment description: (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects|
[Checked in: Comment 4] → (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects|
[Checked in: Comment 4 & 8]
You need to log in
before you can comment on or make changes to this bug.
Description
•