758575 - Port |Bug 636402 - Simplify Sync.js to avoid creating new objects| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P4)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects| [Checked in: Comment 4 & 8]

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 627185 [details] [diff] [review]
(Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects|
[Checked in: Comment 4 & 8]

It is inside the omnijar ifdef for Firefox, is it needed outside (especially for branches)?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to Justin Wood (:Callek) from comment #2)

> It is inside the omnijar ifdef for Firefox,

Because, as often, they missed to update its removed-files.in.

> is it needed outside (especially for branches)?

Yes: Sync.js was removed from the tree.
Yes: that removal happened in 2011.02...

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 627185 [details] [diff] [review]
(Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects|
[Checked in: Comment 4 & 8]

http://hg.mozilla.org/comm-central/rev/e7798995bdc5

Comment 5

[Justin Wood (:Callek)]

There is a list of bugs I just approved for beta (though we're on our last beta now, with the release spinning friday or sat) which touch this same file (removed-files.in)

This is one of those bugs where I could not find a way to apply it to beta, even after mixing and matching the order here repeatedly.

Please either provide one monolithic patch which makes someones life easier, convince someone to untangle, tell us the order, or do it yourself. Otherwise I am comfortable with these slipping from this release.

I won't even attempt to land these patches on aurora for the same reasons without one of the above solutions being done.

Comment 6

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #4)
> http://hg.mozilla.org/comm-central/rev/e7798995bdc5

(In reply to Justin Wood (:Callek) from comment #5)
> tell us the order

Please c-n the 6 changesets in
http://hg.mozilla.org/comm-central/pushloghtml?changeset=e7798995bdc5

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Seriously, roll-up patches wouldn't kill you...

https://hg.mozilla.org/releases/comm-aurora/rev/e23aee37d526
https://hg.mozilla.org/releases/comm-aurora/rev/2f8b759d8f67
https://hg.mozilla.org/releases/comm-aurora/rev/a861f61eb3bb
https://hg.mozilla.org/releases/comm-aurora/rev/3bec5d7aac5a
https://hg.mozilla.org/releases/comm-aurora/rev/105b9574b63d
https://hg.mozilla.org/releases/comm-aurora/rev/da40e0e9a33b

https://hg.mozilla.org/releases/comm-beta/rev/7b59567495cf
https://hg.mozilla.org/releases/comm-beta/rev/fb395b70bc9a
https://hg.mozilla.org/releases/comm-beta/rev/54e677193947
https://hg.mozilla.org/releases/comm-beta/rev/10c4ab8c6f41
https://hg.mozilla.org/releases/comm-beta/rev/72f823ea4cf7
https://hg.mozilla.org/releases/comm-beta/rev/65bfeec082e7

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 627185 [details] [diff] [review]
(Av1) Update packaging after |Bug 636402 - Simplify Sync.js to avoid creating new objects|
[Checked in: Comment 4 & 8]

(In reply to Ryan VanderMeulen from comment #7)

> Seriously, roll-up patches wouldn't kill you...

Noted.

> https://hg.mozilla.org/releases/comm-aurora/rev/e23aee37d526
> 
> https://hg.mozilla.org/releases/comm-beta/rev/7b59567495cf

These are the changesets for this bug.