758592 - [UI] Non logged in users should not see URLs tab

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Schalk Neethling [:espressive]]

Currently the URLs tab on report/list is visible even to users who are not logged in. Even though unauthorized users will not see any data in the tab, it is not the correct behavior for the tab to be visible.

Comment 1

[Schalk Neethling [:espressive]]

Sent pull request :: https://github.com/mozilla/socorro/pull/617

TEST CASE
---------

Viewing report/list as an unauthorized user the URLs tab, far right, should not be visible.

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5d0ca67660042dc6152dede1e2509a39c504bed6
ensure urls tab is only shown to logged in users fixes bug 758592

https://github.com/mozilla/socorro/commit/c0f7acbecf12a0a8fa05ee14314e49debe8a1b78
Merge pull request #617 from ossreleasefeed/ensure-urls-tab-hidden-noauth-users-758592

ensure urls tab is only shown to logged in users fixes bug 758592

Comment 3

[[github robot]]

Commits pushed to admin-refactor at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/5d0ca67660042dc6152dede1e2509a39c504bed6
ensure urls tab is only shown to logged in users fixes bug 758592

https://github.com/mozilla/socorro/commit/c0f7acbecf12a0a8fa05ee14314e49debe8a1b78
Merge pull request #617 from ossreleasefeed/ensure-urls-tab-hidden-noauth-users-758592

Comment 4

[Matt Brandt [:mbrandt]]

Attachment: qa - reopened - url tab visible

It appears that the url tab is still visible when a user is not logged in - it is not selectable.

Comment 5

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/595d2bce99ae78881562e61073fac575b6c9d210
ensure urls tab is only shown to logged in users fixes bug 758592

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verifed on stage - thanks espressive this looks perfect. The url tab now only shows up on the page when an admin user is logged in.

Comment 7

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/36991838617a47f2eb4c07bf1d14e88e9591e8ea
ensure urls tab is only shown to logged in users fixes bug 758592