Last Comment Bug 758626 - account provisioner: cannot subscribe a new email address if there an account provisioner tab already open
: account provisioner: cannot subscribe a new email address if there an account...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: General (show other bugs)
: Trunk
: x86_64 All
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Mike Conley (:mconley) - Getting through review / needinfo backlog
:
:
Mentors:
Depends on:
Blocks: AccountProvisioner
  Show dependency treegraph
 
Reported: 2012-05-25 07:54 PDT by Jb Piacentino
Modified: 2012-05-28 14:23 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
+
fixed


Attachments
Patch v1 (2.61 KB, patch)
2012-05-28 09:39 PDT, Mike Conley (:mconley) - Getting through review / needinfo backlog
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
Patch v2 (carrying over r+/ui-r+ from bwinton) (3.33 KB, patch)
2012-05-28 11:53 PDT, Mike Conley (:mconley) - Getting through review / needinfo backlog
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description User image Jb Piacentino 2012-05-25 07:54:43 PDT
STR:

- Select a suggestion in account provisionner suggestion list -> an account provisionner tab opens
- File/New/Get a new email address... get a suggestion list
- select a suggestion
- suggestion list dlg window does not disappear (beach ball), already opened account provisioner tab is not updated (or no new tab is opened for new suggestion)
Comment 1 User image Mike Conley (:mconley) - Getting through review / needinfo backlog 2012-05-25 13:51:50 PDT
Blake and I talked about this, and we think the ideal behaviour would be that if there is an Account Provisioner tab opened, then going to File > New > Get a New Mail Account should focus that tab.
Comment 2 User image Mike Conley (:mconley) - Getting through review / needinfo backlog 2012-05-28 09:39:47 PDT
Created attachment 627738 [details] [diff] [review]
Patch v1

Assumes patches from the following bugs applied in this order:

bug 757823
bug 758237
bug 758707
bug 758618
bug 758626
Comment 3 User image Mike Conley (:mconley) - Getting through review / needinfo backlog 2012-05-28 09:57:09 PDT
Ok, you should be able to just apply this on top of comm-central properly now, without the other patches (which have now landed).
Comment 4 User image Blake Winton (:bwinton) (:☕️) 2012-05-28 11:20:52 PDT
Comment on attachment 627738 [details] [diff] [review]
Patch v1

Okay, this does seem to do what we agreed on, and it even handles the case where I create an existing mail account, and then hit the button to try to create a new one…  ;)  ui-r=me!

>+++ b/mail/test/mozmill/newmailaccount/test-newmailaccount.js
>@@ -1145,8 +1145,25 @@ function test_search_button_disabled_if_
>+function test_get_new_account_focuses_existing_ap_tab() {
>+  get_to_order_form("green@example.com");
>+  let apTab = mc.tabmail.getTabInfoForCurrentOrFirstModeInstance(
>+    mc.tabmail.tabModes["accountProvisionerTab"]);
>+
>+  // Switch back to the inbox tab.
>+  mc.tabmail.switchToTab(0);
>+
>+  // Try to re-open the provisioner dialog
>+  open_provisioner_window();
>+
>+  // If we got here, that means that we weren't blocked by a dialog
>+  // being opened, which is good.
>+  assert_selected_tab(apTab);
>+  mc.tabmail.closeTab(apTab);
>+}

I think we're okay without testing all the various ways to get to that state, but if you wanted to add a check for launching the accountWizard, and then clicking the "get a new account" button, I wouldn't complain too loudly either.

Other than that, it seems fine to me.

r=me!

Later,
Blake.
Comment 5 User image Mike Conley (:mconley) - Getting through review / needinfo backlog 2012-05-28 11:53:35 PDT
Created attachment 627757 [details] [diff] [review]
Patch v2 (carrying over r+/ui-r+ from bwinton)

Okie doke, I've augmented the test to check the button from the wizard as well.
Comment 6 User image Mike Conley (:mconley) - Getting through review / needinfo backlog 2012-05-28 14:23:27 PDT
comm-central: https://hg.mozilla.org/comm-central/rev/a69ccbd5ab6e
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/edec0900161f
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/0aa1e03d1893

Note You need to log in before you can comment on or make changes to this bug.