Closed
Bug 758626
Opened 12 years ago
Closed 12 years ago
account provisioner: cannot subscribe a new email address if there an account provisioner tab already open
Categories
(Thunderbird :: General, defect)
Tracking
(thunderbird13+ fixed, thunderbird14+ fixed)
RESOLVED
FIXED
Thunderbird 15.0
People
(Reporter: jb, Assigned: mconley)
References
Details
Attachments
(1 file, 1 obsolete file)
3.33 KB,
patch
|
standard8
:
approval-comm-aurora+
standard8
:
approval-comm-beta+
|
Details | Diff | Splinter Review |
STR: - Select a suggestion in account provisionner suggestion list -> an account provisionner tab opens - File/New/Get a new email address... get a suggestion list - select a suggestion - suggestion list dlg window does not disappear (beach ball), already opened account provisioner tab is not updated (or no new tab is opened for new suggestion)
Assignee | ||
Updated•12 years ago
|
Blocks: AccountProvisioner
Assignee | ||
Comment 1•12 years ago
|
||
Blake and I talked about this, and we think the ideal behaviour would be that if there is an Account Provisioner tab opened, then going to File > New > Get a New Mail Account should focus that tab.
Assignee: nobody → mconley
Assignee | ||
Comment 2•12 years ago
|
||
Assumes patches from the following bugs applied in this order: bug 757823 bug 758237 bug 758707 bug 758618 bug 758626
Attachment #627738 -
Flags: ui-review?(bwinton)
Attachment #627738 -
Flags: review?(bwinton)
Assignee | ||
Comment 3•12 years ago
|
||
Ok, you should be able to just apply this on top of comm-central properly now, without the other patches (which have now landed).
Comment 4•12 years ago
|
||
Comment on attachment 627738 [details] [diff] [review] Patch v1 Okay, this does seem to do what we agreed on, and it even handles the case where I create an existing mail account, and then hit the button to try to create a new one… ;) ui-r=me! >+++ b/mail/test/mozmill/newmailaccount/test-newmailaccount.js >@@ -1145,8 +1145,25 @@ function test_search_button_disabled_if_ >+function test_get_new_account_focuses_existing_ap_tab() { >+ get_to_order_form("green@example.com"); >+ let apTab = mc.tabmail.getTabInfoForCurrentOrFirstModeInstance( >+ mc.tabmail.tabModes["accountProvisionerTab"]); >+ >+ // Switch back to the inbox tab. >+ mc.tabmail.switchToTab(0); >+ >+ // Try to re-open the provisioner dialog >+ open_provisioner_window(); >+ >+ // If we got here, that means that we weren't blocked by a dialog >+ // being opened, which is good. >+ assert_selected_tab(apTab); >+ mc.tabmail.closeTab(apTab); >+} I think we're okay without testing all the various ways to get to that state, but if you wanted to add a check for launching the accountWizard, and then clicking the "get a new account" button, I wouldn't complain too loudly either. Other than that, it seems fine to me. r=me! Later, Blake.
Attachment #627738 -
Flags: ui-review?(bwinton)
Attachment #627738 -
Flags: ui-review+
Attachment #627738 -
Flags: review?(bwinton)
Attachment #627738 -
Flags: review+
Assignee | ||
Comment 5•12 years ago
|
||
Okie doke, I've augmented the test to check the button from the wizard as well.
Attachment #627738 -
Attachment is obsolete: true
Assignee | ||
Updated•12 years ago
|
Attachment #627757 -
Flags: approval-comm-beta?
Attachment #627757 -
Flags: approval-comm-aurora?
Assignee | ||
Updated•12 years ago
|
tracking-thunderbird13:
--- → ?
tracking-thunderbird14:
--- → ?
Updated•12 years ago
|
Attachment #627757 -
Flags: approval-comm-beta?
Attachment #627757 -
Flags: approval-comm-beta+
Attachment #627757 -
Flags: approval-comm-aurora?
Attachment #627757 -
Flags: approval-comm-aurora+
Updated•12 years ago
|
Assignee | ||
Comment 6•12 years ago
|
||
comm-central: https://hg.mozilla.org/comm-central/rev/a69ccbd5ab6e comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/edec0900161f comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/0aa1e03d1893
Status: NEW → RESOLVED
Closed: 12 years ago
status-thunderbird13:
--- → fixed
status-thunderbird14:
--- → fixed
OS: Windows 7 → All
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
You need to log in
before you can comment on or make changes to this bug.
Description
•