Closed Bug 758691 Opened 9 years ago Closed 9 years ago

Failure in awesomebar tests with 'Autocomplete popup has been opened'


(Mozilla QA Graveyard :: Mozmill Tests, defect)

Not set


(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 fixed)

Tracking Status
firefox13 --- fixed
firefox14 --- fixed
firefox15 --- fixed
firefox16 --- fixed
firefox-esr10 --- fixed


(Reporter: remus.pop, Assigned: remus.pop)




(Whiteboard: [mozmill-test-failure])


(1 file, 1 obsolete file)

There are lots of failures when we test that autocomplete is opened. Check the report in the url.
This seems to be happening on OSX and Linux. Windows is unaffected.
We do not only want to investigate that failure but fix it. Remus, mind having a look at? I think that we should not use expect.ok() but waitFor().
Summary: Investigate why we fail with 'Autocomplete popup has been opened' → Failure in awesomebar tests with 'Autocomplete popup has been opened'
Whiteboard: [mozmill-test-failure]
If it's possible I would want to try 1 more time to open the autocomplete popup, in case we fail first.
Why would you try to open it again? It should open by a keypress in the locationbar. What I think is that our test is just too fast and we call expect.ok way before the popup has been opened.
Remus, I think that has been fixed by one of your latest fixes. Do you agree?
Yes. Interesting.
Closed: 9 years ago
Resolution: --- → WORKSFORME
This failure seems to be back on Firefox 14 Beta:

As mentioned in comment 1 please change the expect.ok() to waitFor() across branches. Please check all the awesomebar tests. Remus, would you mind working on it?
Resolution: WORKSFORME → ---
Assignee: nobody → remus.pop
Attached patch patch v1 (all branches) (obsolete) — Splinter Review
The only test that was using expect instead of waitFor when waiting for autocompleteResults to be opened was testEscapeAutocomplete.
This apples cleanly on all branches, including esr10.
Attachment #631296 - Flags: review?(hskupin)
Comment on attachment 631296 [details] [diff] [review]
patch v1 (all branches)

>-  expect.ok(!locationBar.autoCompleteResults.isOpened,
>-            "The auto-complete list is closed");
>+  controller.waitFor(function () {
>+    return !locationBar.autoCompleteResults.isOpened;
>+  }, "Autocomplete list has been opened");

nit: this should be 'closed' not 'opened'.
Attachment #631296 - Flags: review?(hskupin) → review-
Fixed the message.
Attachment #631296 - Attachment is obsolete: true
Attachment #631357 - Flags: review?(hskupin)
Attachment #631357 - Flags: review?(hskupin) → review+
Pushed: (default) (aurora)

I have pushed this to default and aurora so we can ensure it is really fixed. If nothing else comes up because of this push lets also backport the patch to older branches.

Thanks Remus!
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
No failures in the last testruns. I think we're safe patching the other branches.
Attachment #631357 - Attachment description: patch v2 (all branches) → patch v2 (all branches) [checked-in]
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.