The default bug view has changed. See this FAQ.

Failure in awesomebar tests with 'Autocomplete popup has been opened'

VERIFIED FIXED

Status

Mozilla QA
Mozmill Tests
VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: RemusPop, Assigned: RemusPop)

Tracking

unspecified

Firefox Tracking Flags

(firefox13 fixed, firefox14 fixed, firefox15 fixed, firefox16 fixed, firefox-esr10 fixed)

Details

(Whiteboard: [mozmill-test-failure], URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
There are lots of failures when we test that autocomplete is opened. Check the report in the url.
This seems to be happening on OSX and Linux. Windows is unaffected.
(Assignee)

Updated

5 years ago
status-firefox14: --- → affected
status-firefox15: --- → affected
We do not only want to investigate that failure but fix it. Remus, mind having a look at? I think that we should not use expect.ok() but waitFor().
Summary: Investigate why we fail with 'Autocomplete popup has been opened' → Failure in awesomebar tests with 'Autocomplete popup has been opened'
Whiteboard: [mozmill-test-failure]
(Assignee)

Comment 2

5 years ago
If it's possible I would want to try 1 more time to open the autocomplete popup, in case we fail first.
Why would you try to open it again? It should open by a keypress in the locationbar. What I think is that our test is just too fast and we call expect.ok way before the popup has been opened.
Remus, I think that has been fixed by one of your latest fixes. Do you agree?
(Assignee)

Comment 5

5 years ago
Yes. Interesting.
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → WORKSFORME
This failure seems to be back on Firefox 14 Beta:

http://mozmill-ci.blargon7.com/#/functional/report/fdec829b93b19c73985be1d3887241c9

As mentioned in comment 1 please change the expect.ok() to waitFor() across branches. Please check all the awesomebar tests. Remus, would you mind working on it?
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
(Assignee)

Updated

5 years ago
Assignee: nobody → remus.pop
(Assignee)

Comment 7

5 years ago
Created attachment 631296 [details] [diff] [review]
patch v1 (all branches)

The only test that was using expect instead of waitFor when waiting for autocompleteResults to be opened was testEscapeAutocomplete.
This apples cleanly on all branches, including esr10.
Attachment #631296 - Flags: review?(hskupin)
Comment on attachment 631296 [details] [diff] [review]
patch v1 (all branches)

>-  expect.ok(!locationBar.autoCompleteResults.isOpened,
>-            "The auto-complete list is closed");
>+  controller.waitFor(function () {
>+    return !locationBar.autoCompleteResults.isOpened;
>+  }, "Autocomplete list has been opened");

nit: this should be 'closed' not 'opened'.
Attachment #631296 - Flags: review?(hskupin) → review-
(Assignee)

Comment 9

5 years ago
Created attachment 631357 [details] [diff] [review]
patch v2 (all branches) [checked-in]

Fixed the message.
Attachment #631296 - Attachment is obsolete: true
Attachment #631357 - Flags: review?(hskupin)
Attachment #631357 - Flags: review?(hskupin) → review+
Pushed:
http://hg.mozilla.org/qa/mozmill-tests/rev/b736bb4acf94 (default)
http://hg.mozilla.org/qa/mozmill-tests/rev/02cd2c196e44 (aurora)

I have pushed this to default and aurora so we can ensure it is really fixed. If nothing else comes up because of this push lets also backport the patch to older branches.

Thanks Remus!
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
status-firefox14: affected → fixed
status-firefox15: affected → fixed
Resolution: --- → FIXED
(Assignee)

Comment 11

5 years ago
No failures in the last testruns. I think we're safe patching the other branches.
status-firefox14: fixed → affected
status-firefox15: fixed → affected
(Assignee)

Updated

5 years ago
status-firefox14: affected → fixed
status-firefox15: affected → fixed
Pushed:
http://hg.mozilla.org/qa/mozmill-tests/rev/eaed72fc6267 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/f3dbdd3c320f (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/baf4925324d3 (esr10)
status-firefox-esr10: --- → fixed
status-firefox13: --- → fixed
status-firefox16: --- → fixed
(Assignee)

Updated

5 years ago
Attachment #631357 - Attachment description: patch v2 (all branches) → patch v2 (all branches) [checked-in]
(Assignee)

Updated

5 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.