758700 - Account Provisioner should give back information on what kind of error it hit when XML is not properly parsed.

Status: RESOLVED INVALID

(Thunderbird :: Account Manager, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

At least one of our account providers returns XML indicating a failure to create an account of a user cancels their transaction, or decides they'd like a different address.

Currently, we take the generated XML, parse it, and when we can't make a server connection out of it, we close the Account Provisioner tab and re-spawn the Account Provisioner dialog.

We should probably give users some more indication of what happened when that dialog re-spawns.

Comment 1

[Ben Bucksch (:BenB)]

You need to agree on an error API with the provider.

The simplest is that they use HTTP 4xx errors, with a user-readable HTTP error message indicating the exact problem. fetchhttp.js will return you that error message in the error callback.

Comment 2

[Ben Bucksch (:BenB)]

For example, if there's a payment problem, I'd use HTTP error 402, with a HTTP error "Credit card rejected by bank due to insufficient credit". I.e. the provider gives a concrete error message, on HTTP level, and you pass that on verbatim to the end user.