The default bug view has changed. See this FAQ.

Account Provisioner checkboxes should be disabled while search in progress

RESOLVED FIXED in Thunderbird 15.0

Status

Thunderbird
Account Manager
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mconley, Assigned: mconley)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 15.0
x86
All

Thunderbird Tracking Flags

(thunderbird13+ fixed, thunderbird14+ fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

STR:

1. Go to File > New > Get a New Mail Account
2. Enter a name, and start the search

What happens?

While the search occurs, the checkboxes to choose providers are still enabled, meaning the user can toggle them. This has the added defect of *re-enabling* the search button, which allows the user to trigger a second search in parallel to the first.

What's expected?

The UI should be locked down (with the exception of closing the window) while the search is in progress. So we should disable those checkboxes.
Created attachment 627325 [details] [diff] [review]
Patch v1

This patch relies on both the patches from bug 757823 and bug 758237 (in that order) being applied.
Attachment #627325 - Flags: ui-review?(bwinton)
Attachment #627325 - Flags: review?(bwinton)
Comment on attachment 627325 [details] [diff] [review]
Patch v1

ui-r=me.

>+++ b/mail/test/mozmill/newmailaccount/test-newmailaccount.js
>+  // Our slow search has started. We have kSearchMSeconds milliseconds before
>+  // the search completes. Plenty of time to check that the right things are
>+  // disabled.

Should we also check that they get re-enabled once the search completes?

r=me either way.
Attachment #627325 - Flags: ui-review?(bwinton)
Attachment #627325 - Flags: ui-review+
Attachment #627325 - Flags: review?(bwinton)
Attachment #627325 - Flags: review+
Created attachment 627340 [details] [diff] [review]
Patch v2 (carrying over r+/ui-r+ from bwinton)

Good call - added those tests.

We want this to ship Account Provisioner.
Attachment #627325 - Attachment is obsolete: true
Attachment #627340 - Flags: approval-comm-beta?
Attachment #627340 - Flags: approval-comm-aurora?
comm-central: https://hg.mozilla.org/comm-central/rev/96cb37390f45
Status: NEW → RESOLVED
Last Resolved: 5 years ago
tracking-thunderbird13: --- → ?
tracking-thunderbird14: --- → ?
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 15.0
Attachment #627340 - Flags: approval-comm-beta?
Attachment #627340 - Flags: approval-comm-beta+
Attachment #627340 - Flags: approval-comm-aurora?
Attachment #627340 - Flags: approval-comm-aurora+
tracking-thunderbird13: ? → +
tracking-thunderbird14: ? → +
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/697fe4fdcf2d
status-thunderbird14: --- → fixed
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/08204ee681fe
status-thunderbird13: --- → fixed
You need to log in before you can comment on or make changes to this bug.