Last Comment Bug 758707 - Account Provisioner checkboxes should be disabled while search in progress
: Account Provisioner checkboxes should be disabled while search in progress
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Account Manager (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 15.0
Assigned To: Mike Conley (:mconley) - (Needinfo me!)
:
Mentors:
Depends on:
Blocks: AccountProvisioner
  Show dependency treegraph
 
Reported: 2012-05-25 11:26 PDT by Mike Conley (:mconley) - (Needinfo me!)
Modified: 2012-05-28 14:07 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
+
fixed
+
fixed


Attachments
Patch v1 (7.00 KB, patch)
2012-05-25 12:42 PDT, Mike Conley (:mconley) - (Needinfo me!)
bwinton: review+
bwinton: ui‑review+
Details | Diff | Splinter Review
Patch v2 (carrying over r+/ui-r+ from bwinton) (7.85 KB, patch)
2012-05-25 13:32 PDT, Mike Conley (:mconley) - (Needinfo me!)
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (Needinfo me!) 2012-05-25 11:26:11 PDT
STR:

1. Go to File > New > Get a New Mail Account
2. Enter a name, and start the search

What happens?

While the search occurs, the checkboxes to choose providers are still enabled, meaning the user can toggle them. This has the added defect of *re-enabling* the search button, which allows the user to trigger a second search in parallel to the first.

What's expected?

The UI should be locked down (with the exception of closing the window) while the search is in progress. So we should disable those checkboxes.
Comment 1 Mike Conley (:mconley) - (Needinfo me!) 2012-05-25 12:42:23 PDT
Created attachment 627325 [details] [diff] [review]
Patch v1

This patch relies on both the patches from bug 757823 and bug 758237 (in that order) being applied.
Comment 2 Blake Winton (:bwinton) (:☕️) 2012-05-25 13:08:46 PDT
Comment on attachment 627325 [details] [diff] [review]
Patch v1

ui-r=me.

>+++ b/mail/test/mozmill/newmailaccount/test-newmailaccount.js
>+  // Our slow search has started. We have kSearchMSeconds milliseconds before
>+  // the search completes. Plenty of time to check that the right things are
>+  // disabled.

Should we also check that they get re-enabled once the search completes?

r=me either way.
Comment 3 Mike Conley (:mconley) - (Needinfo me!) 2012-05-25 13:32:08 PDT
Created attachment 627340 [details] [diff] [review]
Patch v2 (carrying over r+/ui-r+ from bwinton)

Good call - added those tests.

We want this to ship Account Provisioner.
Comment 4 Mike Conley (:mconley) - (Needinfo me!) 2012-05-28 09:53:29 PDT
comm-central: https://hg.mozilla.org/comm-central/rev/96cb37390f45
Comment 5 Mike Conley (:mconley) - (Needinfo me!) 2012-05-28 14:01:09 PDT
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/697fe4fdcf2d
Comment 6 Mike Conley (:mconley) - (Needinfo me!) 2012-05-28 14:07:43 PDT
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/08204ee681fe

Note You need to log in before you can comment on or make changes to this bug.