Remove MindTouch dependencies entirely

NEW
Unassigned

Status

7 years ago
9 months ago

People

(Reporter: lorchard, Unassigned)

Tracking

Details

(Reporter)

Description

7 years ago
Once bug 757940 is closed, we should be able to turn off anything that integrates with MindTouch. 

But, the code will still be around. So, once we've shut down the last MindTouch server for good, we should comb through and remove all integration points entirely.
(Reporter)

Comment 1

7 years ago
* apps/dekicompat - Remove the entire module, see what breaks
* apps/devmo/models.py - Remove UserDocsActivityFeed code, superseded by Kuma models
* apps/devmo/helpers.py - Remove devmo_url() helper, see what breaks
* apps/docs/cron.py - Remove feed code, see bug 759361 and bug 759368
(Reporter)

Comment 2

7 years ago
* apps/devmo/models.py - UserProfile.save() wants to POST to the MindTouch API
Version: Kuma → unspecified
Component: Docs Platform → Editing
Product: Mozilla Developer Network → Mozilla Developer Network
No longer blocks: 756266
Component: Editing → General
I'm seeing this in the save method:

if 'skip_mindtouch_put' in kwargs:
   del kwargs['skip_mindtouch_put']

Do we know if we can quickly whack this?
Flags: needinfo?(lorchard)
(Reporter)

Comment 4

5 years ago
(In reply to David Walsh :davidwalsh from comment #3)
> I'm seeing this in the save method:
> 
> if 'skip_mindtouch_put' in kwargs:
>    del kwargs['skip_mindtouch_put']
> 
> Do we know if we can quickly whack this?

Hmm, I can't find what you're referring to... Got a link to it in github?
Flags: needinfo?(lorchard)
(Reporter)

Comment 6

5 years ago
Yeah, I think this can get taken out. Probably fine, assuming tests all pass. This might be a leftover from the migration way back when
The line referenced in comment 5 is no longer there. It doesn't appear to be anywhere[0].

Is this bug still outstanding?

[0] https://github.com/mozilla/kuma/search?q=skip_mindtouch_put&type=Code&utf8=%E2%9C%93
There are some remaining MindTouch pieces:

https://github.com/mozilla/kuma/search?utf8=%E2%9C%93&q=mindtouch&type=

Some remaining actions:

* Determine if the MindTouch table sort CKEditor plugin [1] still in use, remove if unused
* Update pages with MindTouch-style attachment URLs to new attachment URLs. For example, the :hover page [2] has an old link [3] that redirects to the new link [4].
* Remove the attachment view [5] once old-style attachment URLs have been converted for at least 30 days, to let Google catch up.
* Remove mindtouch IDs from the database [6]
* Update legacy MindTouch links to new link locations. For example, the page User:Diablownik has a link to a tag page [8] that redirects to the new page [9] (this is a poor example, but is the first of many I found).
* Remove the MindTouch redirect view [10] once old-style URLs have been converted for at least 30 days.
* Evaluate other MindTouch instances in the content.

All of this is doable. It could be a manual effort (generate spreadsheet with actions), and some could be done with automation.

[1] https://github.com/mozilla/kuma/blob/00fc05b101658f863f58d7fc2b1aefecbcf71cf8/kuma/static/js/libs/ckeditor/source/plugins/tablesort/plugin.js
[2] https://developer.mozilla.org/en-US/docs/Web/CSS/:hover
[3] https://developer.mozilla.org/@api/deki/files/6247/=css-gallery.zip
[4] https://mdn.mozillademos.org/files/3707/css-gallery.zip
[5] https://github.com/mozilla/kuma/blob/61aea62e532e391c5c8e26e0eaa5049d194ee0ad/kuma/attachments/views.py#L60-L64
[6] https://github.com/mozilla/kuma/blob/79e24a24920e05344096e049c586ad8aecf58038/kuma/attachments/models.py#L129-L139
[7] https://developer.mozilla.org/en-US/docs/User:Diablownik
[8] https://developer.mozilla.org/Special:Tags?tag=Strony_wymagaj%C4%85ce_dopracowania&language=pl
[9] https://developer.mozilla.org/en-US/docs/tags
[10] https://github.com/mozilla/kuma/blob/286948a9ba70454914eacf983015197500c05419/kuma/wiki/views/legacy.py#L24-L56
Component: General → Code Cleanup
You need to log in before you can comment on or make changes to this bug.