Closed Bug 758738 Opened 8 years ago Closed 8 years ago

add support for 'r' pageloader tests as well as fixing raw results

Categories

(Testing :: Talos, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jmaher, Assigned: jmaher)

References

Details

Attachments

(2 files, 3 obsolete files)

the raw results are broken for some aux data.  We need to remove the 314L and make it 314 or send it as a string.

Also for the tdhtml, a11y, tsvg, tsvg_opacity, tsspider, tsscroll we need to run these as we do tp5 in row major with 25 replicates and dropping the first 5. 

We can fine tune this later (hopefully without changes to test names), but we need to adjust for accurate data and this is the first step.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Attachment #627322 - Flags: review?(jhammel)
Attached patch updated with tp5n definition (obsolete) — Splinter Review
back to the future!
Attachment #627322 - Attachment is obsolete: true
Attachment #627322 - Flags: review?(jhammel)
Attachment #627331 - Flags: review?(jhammel)
had the manifest in the wrong place, all good now and it has run on ateam staging.
Attachment #627331 - Attachment is obsolete: true
Attachment #627331 - Flags: review?(jhammel)
Attachment #627926 - Flags: review?(jhammel)
Attachment #627936 - Flags: review?(armenzg)
Blocks: 759329
Blocks: 759330
Comment on attachment 627936 [details] [diff] [review]
add definitions to data.sql in graph server (1.0)

This is an empty patch.
Attachment #627936 - Flags: review?(armenzg) → review-
forgot to qref- although a no change patch should be a r+ ;)
Attachment #627936 - Attachment is obsolete: true
Attachment #627958 - Flags: review?(armenzg)
Depends on: 759336
(In reply to Joel Maher (:jmaher) from comment #6)
> <snip/> although a no change patch should be a r+ ;)

I would have to respectfully disagree :P
Comment on attachment 627926 [details] [diff] [review]
really updated correctly this time (2.0)

Looks good, if tested.  We should really work on getting real JSON serialization going on.  Also, some comment wrt the 'r' tests added would be appreciated
Attachment #627926 - Flags: review?(jhammel) → review+
Depends on: 759374
Comment on attachment 627958 [details] [diff] [review]
add definitions to data.sql in graph server (1.1)

I am trying to be a reviewer for this but I don't know exactly what the last values is supposed to be.
If it is pageset_id to refer to the primary key of the pagesets table, I only see 10 inserts in that data.sql file.

   is_chrome TINYINT UNSIGNED NOT NULL DEFAULT '0',
   is_active TINYINT UNSIGNED NOT NULL DEFAULT '0',
   pageset_id INT UNSIGNED,
let me double check the pageset stuff, I could have a bad patch
for the pageset_id, this should be the same as the original tp5.  The pages are the same, they are just cleaned up a bit.  If there are objections, we could consider making this a new pageset id, although I would prefer not to.
Attachment #627958 - Flags: review?(armenzg) → review?(rhelmer)
Attachment #627958 - Flags: review?(rhelmer) → review+
Depends on: 760207
https://hg.mozilla.org/graphs/rev/2baaf34f2810

All we are waiting on is bug 760207 to put these sql inserts on the live db, then we can start testing, staging, side by side, etc...
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.