758777 - Account Provisioner tab should still act normally if persisted and restored

Status: RESOLVED FIXED

(Thunderbird :: Account Manager, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

STR:

1. Go to File > New > Get a New Mail Account
2. Do a search with Hover.com, choose a result.
3. When the order form tab opens, quit Thunderbird.
4. Restart Thunderbird, and complete your order.

What happens?

The XML listener doesn't get re-attached when the session is restored, so the user sees the XML.

What's expected?

The tab should work as expected, and create the account or head back to the Account Provisioner dialog when it sees XML being passed back.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

This happens because we're not re-attaching our listener when the Account Provisioner tab is restored.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Alternative STR - instead of shutting down TB, just close the tab, and then undo the closure.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Adds persist / restore capabilities to accountProvisionerTab, and modifies our tests to try those functions out.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 627758 [details] [diff] [review]
Patch v1

As mentioned in IRC, since this basically makes things work the way they're supposed to, I don't think it needs a ui-review.

>+++ b/mail/components/newmailaccount/content/accountProvisionerTab.js
>@@ -30,34 +30,66 @@ let accountProvisionerTabType = Object.c
>+  // Since there's only one tab of this type ever, we're OK to stash this
>+  // stuff here.

We should document that assumption somewhere more public, I think.  It seems important.

>+/**
>+ * Re-open the accountProvisionerTab with all fo the stuff we stashed in

Typo: "fo" -> "of".

Other than that, I like it, so r=me, too.

Later,
Blake.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v2 (carrying over r+ from bwinton)

This is pretty low-risk, since it only affects the accountProvisionerTab.

Comment 6

[Mike Conley (:mconley) (:⚙️)]

comm-central: https://hg.mozilla.org/comm-central/rev/49b9049983eb
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/cf972030f616
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/8b55eb005181