Closed Bug 758782 Opened 9 years ago Closed 9 years ago

makefiles: declare mkdir_deps targets .PRECIOUS

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla15

People

(Reporter: joey, Assigned: joey)

References

Details

Attachments

(1 file, 1 obsolete file)

mkdir_deps generated dependencies will be considered an intermediate file and removed when used as a pre-requisite for a wildcard target.

Add ".PRECIOUS: %/.mkdir.done" within config/makefiles/autotargets.mk to inhibit the behavior.  Problem surfaced while compiling idl files { toolkit/components/alerts }.

libalerts_s.a may also suffer from a similar problem:
nsAlertsService.cpp
/usr/bin/ccache c++ -o nsAlertsService.o [...]
rm -f libalerts_s.a
Assignee: nobody → joey
Duplicate of this bug: 758780
Comment on attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

Flag directory creation deps as .PRECIOUS to inhibit removal when they are considered an "intermediate file".
Attachment #627370 - Flags: review?(ted.mielczarek)
Comment on attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

Review of attachment 627370 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/autotargets.mk
@@ +18,5 @@
>  MKDIR ?= mkdir -p
>  TOUCH ?= touch
>  
> +# Deps will be considered intermediate when used as a pre-requisite for
> +# wildcard targets.  Inhibit their removal, mkdir -p is a standlaone op.

typo in standalone
Attachment #627370 - Flags: review?(ted.mielczarek) → review+
Attachment #627370 - Attachment is obsolete: true
Comment on attachment 628388 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

r=glandium carried forward.

Fixed typo in 'standalone' spelling.
Attachment #628388 - Flags: review?(ted.mielczarek)
Attachment #628388 - Flags: review?(ted.mielczarek)
https://hg.mozilla.org/mozilla-central/rev/2e755d7847ac
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.