makefiles: declare mkdir_deps targets .PRECIOUS

RESOLVED FIXED in mozilla15

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: joey, Assigned: joey)

Tracking

unspecified
mozilla15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
mkdir_deps generated dependencies will be considered an intermediate file and removed when used as a pre-requisite for a wildcard target.

Add ".PRECIOUS: %/.mkdir.done" within config/makefiles/autotargets.mk to inhibit the behavior.  Problem surfaced while compiling idl files { toolkit/components/alerts }.

libalerts_s.a may also suffer from a similar problem:
nsAlertsService.cpp
/usr/bin/ccache c++ -o nsAlertsService.o [...]
rm -f libalerts_s.a
(Assignee)

Updated

5 years ago
Assignee: nobody → joey
(Assignee)

Updated

5 years ago
Duplicate of this bug: 758780
(Assignee)

Comment 2

5 years ago
Created attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS
(Assignee)

Comment 3

5 years ago
Comment on attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

Flag directory creation deps as .PRECIOUS to inhibit removal when they are considered an "intermediate file".
Attachment #627370 - Flags: review?(ted.mielczarek)
Comment on attachment 627370 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

Review of attachment 627370 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/autotargets.mk
@@ +18,5 @@
>  MKDIR ?= mkdir -p
>  TOUCH ?= touch
>  
> +# Deps will be considered intermediate when used as a pre-requisite for
> +# wildcard targets.  Inhibit their removal, mkdir -p is a standlaone op.

typo in standalone
Attachment #627370 - Flags: review?(ted.mielczarek) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 628388 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS
(Assignee)

Updated

5 years ago
Attachment #627370 - Attachment is obsolete: true
(Assignee)

Comment 6

5 years ago
Comment on attachment 628388 [details] [diff] [review]
mkdir_deps dependencies should be .PRECIOUS

r=glandium carried forward.

Fixed typo in 'standalone' spelling.
Attachment #628388 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 7

5 years ago
Try job: https://tbpl.mozilla.org/?tree=Try&rev=f47e7fde1a62
(Assignee)

Updated

5 years ago
Attachment #628388 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 8

5 years ago
Inbound push: https://hg.mozilla.org/integration/mozilla-inbound/rev/2e755d7847ac

Comment 9

5 years ago
https://hg.mozilla.org/mozilla-central/rev/2e755d7847ac
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
You need to log in before you can comment on or make changes to this bug.