758798 - Liberate TextSwitcher from different font-sizes.

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As per the font-sizes used and the action-bar height, the tabs counter should have the following values:
gingerbread - 22sp.
honeycomb - 24sp.
ics - portrait - 24sp.
ics - landscape - 20sp.
ics - tablet - 26sp.

It's better to have them in dimens.xml instead of doing them in code.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

This patches adds different dimens.xml to deal with different sizes. The color is now with colors.xml (killing mCounterColor, yaaay!)
The layout is moved to tabs_counter.xml, and inflated when needed.

The other approach would be to inflate once, clone it and fix the text-size. I can try doing that.

Comment 2

[Sriram Ramasubramanian [:sriram]]

Update: clone() cannot be used on TextView as the access is barred in Android. So, the above patch is the best way to do.

Comment 3

[Sriram Ramasubramanian [:sriram]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/16cf8e199b6a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/16cf8e199b6a