758822 - For non-AMO-hosted add-ons, the post-install doorhanger notification icon remains in location bar until you click it (and then it vanishes)

Status: NEW

(Toolkit :: General, defect)

Description

[Daniel Holbert [:dholbert]]

STR:
 1. Visit http://noscript.net/getit
 2. Click giant green "INSTALL" button
 3. Click through the install steps
 4. Click "Allow", then "Install Now" on the doorhanger/dialog that appears
 5. When the "NoScript will be installed after you restart Nightly" doorhanger appears, click outside of it to dismiss it, or hit the "x" on that doorhanger.

EXPECTED RESULTS: Doorhanger notification icon disappears from location bar.

ACTUAL RESULTS: Doorhanger notification icon remains in location bar. [but it's useless -- if I click it to see what it's trying to tell me, *THEN* it disappears]

Firefox release has EXPECTED RESULTS:
 Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:12.0) Gecko/20100101 Firefox/12.0

Nightly has ACTUAL RESULTS:
 Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/15.0 Firefox/15.0a1

(testing w/ fresh profile in both cases)

Also: This doesn't seem to affect addons hosted on AMO.  e.g. if I repeat STR with
 https://addons.mozilla.org/en-US/firefox/addon/download-statusbar/
instead of the noscript-hosted page, then Nightly gives EXPECTED RESULTS.  Not sure if this is from an HTTPS vs HTTP distinction, or some AMO-is-magic-related thing.

Comment 1

[Daniel Holbert [:dholbert]]

From mozregression:

Last good nightly: 2012-04-18
First bad nightly: 2012-04-19

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0c7e2911be75&tochange=da53be684794

Bug 745744 looks most related in that range. Tentatively flagging as a regression from that.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #1)
> Bug 745744 looks most related in that range. Tentatively flagging as a
> regression from that.

Confirmed, with local backout of http://hg.mozilla.org/mozilla-central/rev/218a9ef79151
That's the changeset that triggered this behavior.

In trunk, the "after you restart" doorhanger's icon remains in the location bar until you click that icon.
...VS...
In old nightlies and trunk-with-218a9ef79151-backed-out, that doorhanger's icon disappears after you dismiss the notification.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

I need then some help from Firefox team.
We really really don't want to back out Bug 745744, since it is rather horrible
memory leak and responsiveness bug.

Comment 4

[Tony Mechelynck [:tonymec]]

In reply to comment #0: Isn't your "Actual results" the desired behaviour? All doorhangers that I know of keep their icon in the URL bar until you browse to a different page. This allows redisplaying the notification in case you unwittingly dismissed it, e.g. by clicking some link in the page just as the doorhanger opened.

Comment 5

[Daniel Holbert [:dholbert]]

(In reply to Tony Mechelynck [:tonymec] from comment #4)
> In reply to comment #0: Isn't your "Actual results" the desired behaviour?
> All doorhangers that I know of keep their icon in the URL bar until you
> browse to a different page. This allows redisplaying the notification in
> case you unwittingly dismissed it, e.g. by clicking some link in the page
> just as the doorhanger opened.

Almost -- it *almost* behaves as you describe -- but not quite, which makes it all the more diabolical.

If you click the icon, you *expect* the notification to redisplay (like you said) -- but in this case, it instead *mysteriously disappears* when you click it.  The old behavior was much better, IMHO -- for it to disappear up-front (and get out of your way), rather than having it stick around & pretending to still be there, only to mysteriously disappear when you try to investigate.  (I'd be fine with the alternate behavior you described, too, though -- having the icon stick around & _actually_ redisplay the notification again when you click it.)

Comment 6

[:Gavin Sharp [email: [e-mail]]]

In general, notifications stay present until you explicitly dismiss them. The "add-on installation complete" doorhanger specifies the removeOnDismissal option, though, which is supposed to cause it to be removed whenever the notification is dismissed (e.g. by clicking somewhere else on the screen - see http://hg.mozilla.org/mozilla-central/rev/1b1f64871b74). The patch for bug 745744 must have broken that functionality somehow. It's a little bit odd because we do have a test for that functionality in general, so this may be something specific to the add-on prompts.